Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling cloudwatch auto scaling group metrics collection for HA mode #17

Closed
wants to merge 1 commit into from

Conversation

denvazh
Copy link
Contributor

@denvazh denvazh commented Mar 1, 2024

For more serious use and use in production environment I found that I would like to have some way to setup alerts.
It seems Auto Scaling group by default has corresponding metrics collection disabled and its up to the user to either enable allow of them or enable specific ones.

This change allows specifying ( and thus enabling collection ) for specific Auto Scaling group metrics.

Group metrics are available at one-minute granularity at no additional charge, but you must enable them.

Docs: https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-metrics.html

Example when changes are applied and collection of GroupInServiceInstances metric was enabled.
asg_metrics_working

@RaJiska
Copy link
Owner

RaJiska commented Mar 24, 2024

Thank you @denvazh , this is a great addition.

Considering enabling those metrics is free as you pointed out, I believe those should be enabled by default as there is no downside to having them. I'd even say it could be great if a couple more could be enabled, such as:

  • GroupInServiceInstances,
  • GroupPendingInstances,
  • GroupStandbyInstances, and,
  • GroupTerminatingInstances

@denvazh
Copy link
Contributor Author

denvazh commented Mar 24, 2024

@RaJiska Sure! Let me adjust the code to reflect that idea and have metrics you've mentioned enabled by default 👍

@RaJiska
Copy link
Owner

RaJiska commented Jun 17, 2024

Completed through #24, thank you @denvazh.

@RaJiska RaJiska closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants