Handle "+", fix file objects and refactor SmartOpenHttpTest #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Feb 23, 2019
Signed-off-by: Vadim Markovtsev <[email protected]>
Signed-off-by: Vadim Markovtsev <[email protected]>
|
@piskvorky CI passed, review suggestions addressed. Regarding the print(open("smart_open/tests/test_smart_open.py").name)does print the opened file name. I added comments at that line. |
|
As a nice side effect, this will work: with open("file.gz", "rb") as f:
decompressed_data = smart_open(f).read()or this with smart_open(open("file.gz", "wb"), "w") as f:
f.write("data") |
|
Thanks a lot! That "side effect" is awesome, love it :) |
mpenkov
requested changes
Feb 24, 2019
vmarkovtsev
changed the title
vmarkovtsev
force-pushed
the
master
branch
2 times, most recently
from
5e11016 to
d576123
Compare
Signed-off-by: Vadim Markovtsev <[email protected]>
|
@mpenkov Review applied, the controversial function removed, ready for the next round. |
mpenkov
requested changes
Feb 26, 2019
Signed-off-by: Vadim Markovtsev <[email protected]>
|
Addressed |
mpenkov
requested changes
Feb 26, 2019
Signed-off-by: Vadim Markovtsev <[email protected]>
|
Addressed |
mpenkov
approved these changes
Feb 26, 2019
|
@piskvorky Looks good enough to merge for me, WDYT? |
vmarkovtsev
changed the title
|
This PR has been heavily reviewed and is fairly low risk. In the interest of keeping the ball rolling, I'm going to merge it. @piskvorky Please let me know if there are any issues. |
|
@vmarkovtsev Thanks again for your contribution, keep them coming 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadim Markovtsev [email protected]
It all started with the refactoring suggestion in #260 (comment) and went a little bit too far:
read()disregarding the actual open mode. I added_is_stream()function and fixed that.nameattribute check to the file objects handler. Thus it becomes possible to open a regular stream, specifynameand read/write compressed data. This was a prerequisite for the "file-less"SmartOpenHttpTest-s.Then I started writing the tests and found a few minor bugs:
_compression_wrapper(). All three compression codecs do not support reading and writing at the same time._encoding_wrapper(): only the reader's encoder was applied. I changed that to chaining reader's and writer's encoders in rw modes.