Add support for .xz / lzma #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Feb 20, 2019
Signed-off-by: Vadim Markovtsev <[email protected]>
Signed-off-by: Vadim Markovtsev <[email protected]>
Signed-off-by: Vadim Markovtsev <[email protected]>
|
@piskvorky CI passed, README updated, py2.7 handled. PTAL |
|
Thanks for the swift resolution! @mpenkov WDYT? |
piskvorky
approved these changes
Feb 20, 2019
mpenkov
requested changes
Feb 21, 2019
| def test_http_xz(self): | ||
| """Can open xz via http?""" | ||
| test_string = b'Hello World Compressed.' | ||
| # |
There was a problem hiding this comment.
Yes, I agree with the text in this TODO. We should avoid unnecessary file IO (create temporary file, write to file, read from file, delete file) in unit tests, especially when the alternative is cleaner and simpler (encode to a io.BytesIO directly).
There was a problem hiding this comment.
This has been copied from test_http_bz. I understand that you wish to refactor the tests, but the goal of this PR is different. I will submit a refactoring PR separately, ok?
|
Sorry for the mess, the work continues in #262 as I accidentally removed my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadim Markovtsev [email protected]