Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types #1

Closed
wants to merge 39 commits into from
Closed

Types #1

wants to merge 39 commits into from

Conversation

Rafiot
Copy link
Owner

@Rafiot Rafiot commented Sep 11, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

Rafiot and others added 28 commits December 3, 2024 10:57
@Rafiot
new: Initial merge types-redis
cbf1ae3 
Related valkey-io#84

Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
More rename, add few types
48ac4a4 
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
make mypy happy
7d75d41 
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
new: MyPy Github actions
3340e26 
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
fix: python < 3.10 compat
7bff49e 
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
Fixup typing for test suite (async)
64bcdc1 
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
new: typecheck more tests
9febbc0 
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
v6.0.2
aa44eac 
Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
check typing on bloom and cache
99d2079 
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
smembers returns a list, not a set.
71265af 
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
add more tests on mypy
d22dbe3 
Signed-off-by: Raphaël Vinot <[email protected]>
@mkmkme @Rafiot
tests: added forgotten asserts in test_geosearch_member
0a490f2 
These lines were missing the `assert` keyword and hence were
meaningless.

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@mkmkme @Rafiot
tests: added async geosearch tests
802ee26 
These tests were copied from the sync tests and adapted to use the async
client.

This commit fixes valkey-io#63

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@amirreza8002 @Rafiot
make documentation link more obvious
f1a8c3f 
Signed-off-by: amirreza <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@amirreza8002 @Rafiot
Deleted outdated link
6b5f6f0 
Signed-off-by: amirreza <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
doc: fix rst format
6e7db0b 
Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@ArtemIsmagilov @Rafiot
drop compose format and commands v1, use supported v2+
1c8a665 
Signed-off-by: ArtemIsmagilov <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@dependabot @Rafiot
build(deps): bump actions/cache from 3 to 4
68d58d1 
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@dependabot @Rafiot
build(deps): bump rojopolis/spellcheck-github-actions
b9d9ca0 
Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.41.0 to 0.42.0.
- [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases)
- [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md)
- [Commits](rojopolis/spellcheck-github-actions@0.41.0...0.42.0)

---
updated-dependencies:
- dependency-name: rojopolis/spellcheck-github-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@ArtemIsmagilov @Rafiot
sort methods acl_deluser and acl_dryrun by alphabetically, checke…
fde6bab 
…d doc

Signed-off-by: ArtemIsmagilov <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
Temporarily fix actions/runner-images#10781
7823618 
Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
parsers: resp3: be less verbose
60fa28a 
Close valkey-io#111

Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
Revert "Temporarily fix actions/runner-images#10781"
8ec92e8 
This reverts commit 318019a.

Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot
chg: Sync with upstream
39616e9 
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
Temporarily fix actions/runner-images#10781
564231c 
Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
Revert "Temporarily fix actions/runner-images#10781"
fd67799 
This reverts commit 318019a.

Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@dependabot @Rafiot
build(deps): bump rojopolis/spellcheck-github-actions
9bca022 
Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.42.0 to 0.44.0.
- [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases)
- [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md)
- [Commits](rojopolis/spellcheck-github-actions@0.42.0...0.44.0)

---
updated-dependencies:
- dependency-name: rojopolis/spellcheck-github-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@zioproto @Rafiot
Set socket_timeout default value to 5 seconds
b26e9e9 
Fixes valkey-io#119

Signed-off-by: Saverio Proto <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
mkmkme and others added 11 commits December 3, 2024 11:01
@mkmkme @Rafiot
tests: take into account changed behaviour of READONLY
6e2d71d 
Behaviour of READONLY was changed in
valkey-io/valkey#325 which became a part of
8.0.0. This caused test_readonly_invalid_cluster_state to fail.

This commit takes into account this change.

Signed-off-by: Mikhail Koviazin <[email protected]>
@mkmkme @Rafiot
tests: mark test_hash for skipping
4325ae2 
Hash commands are part of proprietary module that Valkey does not
implement for now. Mark them for skipping just like JSON and search.

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@mkmkme @Rafiot
tests: make test_client_kill_filter_by_maxage more robust
93b1e6a 
Previously the test relied on the amount of clients that are currently
connected to the server. This is not robust as this can be affected by
the outside or a bad timing. This caused quite a lot of test case
failures.
The proper way to handle this is:
* Create a client and assign a distinguishable name to it
* Verify it's in `CLIENT LIST`
* Sleep for enough time for it to be killed by maxage we provide
* Verify it's not anymore in `CLIENT LIST`

This commit does exactly that.

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
Bump minimum libvalkey version to 4.0.1
a87c4b7 
Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@mkmkme @Rafiot
Update SSL certificates to include key usage
92137ef 
In Python 3.13, `ssl.create_default_context()` added
`VERIFY_X509_STRICT` to the flags by default which caused the tests to
fail due to missing key usage. This commit adds it to the certificate
configuration and replaces the certificates with reconfigured ones.

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@mkmkme @Rafiot
tests: fix TLS tests with Python 3.13
dd7c56d 
This commit adds support for minimum_ssl_version and maximum_ssl_version
to `_ValkeyTCPServer` in tests. Previously it was written with
`ssl.wrap_socket` in mind which only supported `ssl_version`.
`SSLContext` OTOH supports passing both minimum and maximum supported TLS
versions. This commit utilizes that.

Additionally, TLS version in test_tcp_ssl_version_mismatch was fixed.
It was broken since 7783e0b. This change was added there by mistake and
in fact didn't change anything for Python 3.12. Instead, it seems to
have hidden a bug that revealed itself with Python 3.13.

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
Add support for Python 3.13
70491ae 
Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@aiven-sal @Rafiot
Remove expiration/TTL commands that are not supported by Valkey
32108c2 
Support for this commands may come in the future[1].
But it will take some time, so for now it's better
to drop them.

This is a breaking change for 6.1.

Close valkey-io#78

[1]: valkey-io/valkey#640

Signed-off-by: Salvatore Mesoraca <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@dependabot @Rafiot
build(deps): bump codecov/codecov-action from 4 to 5
0d56584 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4...v5)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@dependabot @Rafiot
build(deps): bump rojopolis/spellcheck-github-actions
c147911 
Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.44.0 to 0.45.0.
- [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases)
- [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md)
- [Commits](rojopolis/spellcheck-github-actions@0.44.0...0.45.0)

---
updated-dependencies:
- dependency-name: rojopolis/spellcheck-github-actions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@mkmkme @Rafiot
v6.1.0b1
121ce37 
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Raphaël Vinot <[email protected]>
@Rafiot Rafiot closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rafiot @aiven-sal @mkmkme @amirreza8002 @ArtemIsmagilov @zioproto