Extract verification of incorrect any usage to separate method

RailsEventStore · Jul 26, 2021 · 378cef3 · 378cef3
1 parent 391ec8e
commit 378cef3
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/ruby_event_store/lib/ruby_event_store/in_memory_repository.rb b/ruby_event_store/lib/ruby_event_store/in_memory_repository.rb
@@ -37,14 +37,7 @@ def append_to_stream(records, stream, expected_version)
       serialized_records = records.map { |record| record.serialize(serializer) }
 
       with_synchronize(expected_version, stream) do |resolved_version|
-        if @verify_incorrect_any_usage
-          stream_positions = streams.fetch(stream.name, Array.new).map(&:position)
-          if resolved_version.nil?
-            raise UnsupportedVersionAnyUsage if !stream_positions.compact.empty?
-          else
-            raise UnsupportedVersionAnyUsage if stream_positions.include?(nil)
-          end
-        end
+        verify_incorrect_any_usage(resolved_version, stream)
         raise WrongExpectedEventVersion unless resolved_version.nil? || last_stream_version(stream).equal?(resolved_version)
 
         serialized_records.each_with_index do |serialized_record, index|
@@ -61,14 +54,7 @@ def link_to_stream(event_ids, stream, expected_version)
       serialized_records = event_ids.map { |id| read_event(id) }
 
       with_synchronize(expected_version, stream) do |resolved_version|
-        if @verify_incorrect_any_usage
-          stream_positions = streams.fetch(stream.name, Array.new).map(&:position)
-          if resolved_version.nil?
-            raise UnsupportedVersionAnyUsage if !stream_positions.compact.empty?
-          else
-            raise UnsupportedVersionAnyUsage if stream_positions.include?(nil)
-          end
-        end
+        verify_incorrect_any_usage(resolved_version, stream)
         raise WrongExpectedEventVersion unless resolved_version.nil? || last_stream_version(stream).equal?(resolved_version)
 
         serialized_records.each_with_index do |serialized_record, index|
@@ -229,6 +215,17 @@ def add_to_stream(stream, serialized_record, resolved_version, index)
       streams[stream.name] << EventInStream.new(serialized_record.event_id, compute_position(resolved_version, index))
     end
 
+    def verify_incorrect_any_usage(resolved_version, stream)
+      if @verify_incorrect_any_usage
+        stream_positions = streams.fetch(stream.name, Array.new).map(&:position)
+        if resolved_version.nil?
+          raise UnsupportedVersionAnyUsage if !stream_positions.compact.empty?
+        else
+          raise UnsupportedVersionAnyUsage if stream_positions.include?(nil)
+        end
+      end
+    end
+
     attr_reader :streams, :mutex, :storage, :serializer, :next_global_position
   end
 end