Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InMemoryRepository - verify no mixing between expected_versions: :any and Integer #420

Closed
paneq opened this issue Aug 7, 2018 · 2 comments
Assignees

Comments

@paneq
Copy link
Member

paneq commented Aug 7, 2018

Recently I had 2 developers contacting me who published with inconsistent expected_version to the same stream. They used AggregateRoot and they manually published outside of it to the same stream. This is not supported.

However it would be costly for our 2-table schema to verify this assumption so we don't check and silently accept it even though reading the data would lead to an incorrect order (and it does).

But we could warn them if our InMemoryRepository which is likely used in tests would raise an exception in such case. What do you think?

@mostlyobvious
Copy link
Member

Makes sense if that repository is primarily used in tests.

@swistak35
Copy link
Contributor

Done in #1091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants