-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefaultApplyStrategy for AggregateRoot fails when using protobuf #578
Labels
Comments
obahareth
changed the title
DefaultApplyStrategy fails when using protobuf
DefaultApplyStrategy for AggregateRoot fails when using protobuf
May 1, 2019
@obahareth Nice catch. This might fix it #579 , could you give it a try? It's just PoC. |
#579 does fix it, thanks! |
Continued in #582 |
Fix has been released in v0.40.0: https://github.com/RailsEventStore/rails_event_store/releases/tag/v0.40.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When you use Protobuf for your events along with AggregateRoot, the AggregateRoot default apply strategy tries to call a handler called
apply_proto
because it isn't reading the event class (It's readingevent.class
instead ofevent.data.class
in the case of protobuf). It seems like we need a different apply strategy for protobuf.The examples below all work if you use the default events and YAML, but when switching to Protobuf they don't.
Sample output
Sample aggregate
The text was updated successfully, but these errors were encountered: