Make browser history know about pagination #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you enter (manually) to paginated URL, it will work. A lot of bad things happened in that commit. We will retract later :)
swistak35
force-pushed
the
rl-browser-pagination-history
branch
from
a997c6b to
1e3e8b7
Compare
This is an extension to the provided stdlib, so deal with that :D Naming comes from the fact that community extensions to, for example, Maybe, are named "Maybe.Extra".
No more needed
swistak35
force-pushed
the
rl-browser-pagination-history
branch
from
649c2ef to
cf8a0ab
Compare
|
A few more design (as in: code) improvements could be made:
I have a thought that instead of decomposing the model/flags and passing down only subset of fields, it would be better in most cases to pass whole model/flags, and decompose only if we are really on the bottom of displaying something. For example, I needed to pass down much more data into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.