Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late to the party: testing on Rails 8 #1833

Closed
wants to merge 12 commits into from
Closed

Late to the party: testing on Rails 8 #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bb87c3a
Late to the party: testing on Rails 8
fidel Dec 31, 2024
f05deb7
ActiveRecord expects sqlite >= 2.1
fidel Dec 31, 2024
bbb3c0d
Dummy Rails 8 app
fidel Dec 31, 2024
5bea6dc
One bridge too far
fidel Dec 31, 2024
b1feec6
Shared gemfiles are cool, unless they aren't
fidel Dec 31, 2024
495f9b4
Yikes
fidel Jan 2, 2025
4d95052
Inline Gemfile.database
fidel Jan 2, 2025
d6578d8
Exclude Gemfile with Rails 8 from testing on Ruby 3.1
fidel Jan 2, 2025
e8127ac
I believe we can test protobuf on more recent Ruby
fidel Jan 2, 2025
ac594de
Don't run protobuf on Rails 8 with Ruby 3.1
fidel Jan 2, 2025
b28127a
Drop Ruby 3.1 testing as it won't work with Rails 8
fidel Jan 2, 2025
0498570
join like a szczupac
fidel Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/dres_client_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ jobs:
bundle_gemfile: Gemfile
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/minitest-ruby_event_store_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
bundle_gemfile: Gemfile
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
steps:
- uses: actions/checkout@v4
with:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/rails_event_store_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,12 @@ jobs:
bundle_gemfile: Gemfile
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_7_1
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile.rails_7_1
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
bundle_gemfile: Gemfile.rails_7_1
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_7_0
- ruby_version: ruby-3.3
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/ruby_event_store-active_record_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ jobs:
bundle_gemfile: Gemfile
database_url: sqlite3:db.sqlite3
data_type: binary
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.activerecord_7_1
database_url: sqlite3:db.sqlite3
data_type: binary
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.activerecord_7_0
database_url: sqlite3:db.sqlite3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ruby_event_store-flipper_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ jobs:
bundle_gemfile: Gemfile
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.activesupport_7_1
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.activesupport_7_0
- ruby_version: ruby-3.3
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ruby_event_store-newrelic_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
bundle_gemfile: Gemfile
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
steps:
- uses: actions/checkout@v4
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ruby_event_store-outbox_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ jobs:
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
database_url: sqlite3:db.sqlite3
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_7_1
database_url: sqlite3:db.sqlite3
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_7_0
database_url: sqlite3:db.sqlite3
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ruby_event_store-profiler_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
bundle_gemfile: Gemfile
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruby_event_store-protobuf_coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
fail-fast: false
matrix:
include:
- ruby_version: ruby-3.2
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruby_event_store-protobuf_mutate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
fail-fast: false
matrix:
include:
- ruby_version: ruby-3.2
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile
steps:
- uses: actions/checkout@v4
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/ruby_event_store-protobuf_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,22 @@ jobs:
fail-fast: false
matrix:
include:
- ruby_version: ruby-3.2
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile
database_url: sqlite3:db.sqlite3
- ruby_version: ruby-3.1
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile
database_url: sqlite3:db.sqlite3
- ruby_version: ruby-3.2
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_7_1
database_url: sqlite3:db.sqlite3
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_7_0
database_url: sqlite3:db.sqlite3
- ruby_version: ruby-3.2
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_6_1
database_url: sqlite3:db.sqlite3
- ruby_version: ruby-3.2
- ruby_version: ruby-3.3
bundle_gemfile: Gemfile.rails_6_0
database_url: sqlite3:db.sqlite3
steps:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ruby_event_store-transformations_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ jobs:
bundle_gemfile: Gemfile
- ruby_version: ruby-3.2
bundle_gemfile: Gemfile
- ruby_version: ruby-3.1
bundle_gemfile: Gemfile
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion aggregate_root/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ gemspec
eval_gemfile "../support/bundler/Gemfile.shared"

gem "ruby_event_store", path: ".."
gem "activesupport", "~> 7.1.3"
gem "activesupport", "~> 8.0.1"
22 changes: 14 additions & 8 deletions aggregate_root/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,30 @@ PATH
GEM
remote: https://rubygems.org/
specs:
activesupport (7.1.3.4)
activesupport (8.0.1)
base64
benchmark (>= 0.3)
bigdecimal
concurrent-ruby (~> 1.0, >= 1.0.2)
concurrent-ruby (~> 1.0, >= 1.3.1)
connection_pool (>= 2.2.5)
drb
i18n (>= 1.6, < 2)
logger (>= 1.4.2)
minitest (>= 5.1)
mutex_m
tzinfo (~> 2.0)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
ast (2.4.2)
base64 (0.2.0)
bigdecimal (3.1.8)
benchmark (0.4.0)
bigdecimal (3.1.9)
concurrent-ruby (1.3.3)
connection_pool (2.4.1)
diff-lcs (1.5.1)
drb (2.2.1)
i18n (1.14.5)
i18n (1.14.6)
concurrent-ruby (~> 1.0)
logger (1.6.4)
minitest (5.23.1)
mutant (0.12.0)
diff-lcs (~> 1.3)
Expand All @@ -45,7 +50,6 @@ GEM
mutant-rspec (0.12.0)
mutant (= 0.12.0)
rspec-core (>= 3.8.0, < 4.0.0)
mutex_m (0.2.0)
parser (3.3.3.0)
ast (~> 2.4.1)
racc
Expand All @@ -65,20 +69,22 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
securerandom (0.4.1)
sorbet-runtime (0.5.11429)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unparser (0.6.14)
diff-lcs (~> 1.3)
parser (>= 3.3.0)
uri (1.0.2)

PLATFORMS
arm64-darwin
x86_64-darwin
x86_64-linux

DEPENDENCIES
activesupport (~> 7.1.3)
activesupport (~> 8.0.1)
aggregate_root!
mutant (= 0.12.0)
mutant-minitest (= 0.12.0)
Expand Down
2 changes: 1 addition & 1 deletion contrib/ruby_event_store-flipper/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ gem "ruby_event_store-rspec", path: "../.."

gem "flipper", "~> 0.19"
gem "byebug"
gem "activesupport", "~> 7.1.3"
gem "activesupport", "~> 8.0.1"
12 changes: 12 additions & 0 deletions contrib/ruby_event_store-flipper/Gemfile.activesupport_7_1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# frozen_string_literal: true

source "https://rubygems.org"
gemspec

eval_gemfile "../../support/bundler/Gemfile.shared"
gem "ruby_event_store", path: "../.."
gem "ruby_event_store-rspec", path: "../.."

gem "flipper", "~> 0.19"
gem "byebug"
gem "activesupport", "~> 7.1.5"
104 changes: 104 additions & 0 deletions contrib/ruby_event_store-flipper/Gemfile.activesupport_7_1.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
PATH
remote: ../..
specs:
ruby_event_store (2.15.0)
concurrent-ruby (~> 1.0, >= 1.1.6)
ruby_event_store-rspec (2.15.0)
rspec (~> 3.0)

PATH
remote: .
specs:
ruby_event_store-flipper (0.2.1)
ruby_event_store (>= 1.0.0)

GEM
remote: https://rubygems.org/
specs:
activesupport (7.1.5.1)
base64
benchmark (>= 0.3)
bigdecimal
concurrent-ruby (~> 1.0, >= 1.0.2)
connection_pool (>= 2.2.5)
drb
i18n (>= 1.6, < 2)
logger (>= 1.4.2)
minitest (>= 5.1)
mutex_m
securerandom (>= 0.3)
tzinfo (~> 2.0)
ast (2.4.2)
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.9)
byebug (11.1.3)
concurrent-ruby (1.3.4)
connection_pool (2.4.1)
diff-lcs (1.5.1)
drb (2.2.1)
flipper (0.28.3)
concurrent-ruby (< 2)
i18n (1.14.6)
concurrent-ruby (~> 1.0)
logger (1.6.4)
minitest (5.25.4)
mutant (0.12.0)
diff-lcs (~> 1.3)
parser (~> 3.3.0)
regexp_parser (~> 2.9.0)
sorbet-runtime (~> 0.5.0)
unparser (~> 0.6.9)
mutant-minitest (0.12.0)
minitest (~> 5.11)
mutant (= 0.12.0)
mutant-rspec (0.12.0)
mutant (= 0.12.0)
rspec-core (>= 3.8.0, < 4.0.0)
mutex_m (0.3.0)
parser (3.3.6.0)
ast (~> 2.4.1)
racc
racc (1.8.1)
rake (13.2.1)
regexp_parser (2.9.3)
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.2)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.3)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.2)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.2)
securerandom (0.4.1)
sorbet-runtime (0.5.11708)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unparser (0.6.15)
diff-lcs (~> 1.3)
parser (>= 3.3.0)

PLATFORMS
arm64-darwin-24
ruby

DEPENDENCIES
activesupport (~> 7.1.5)
byebug
flipper (~> 0.19)
mutant (= 0.12.0)
mutant-minitest (= 0.12.0)
mutant-rspec (= 0.12.0)
rake (>= 10.0)
rspec (~> 3.6)
ruby_event_store!
ruby_event_store-flipper!
ruby_event_store-rspec!

BUNDLED WITH
2.5.15
Loading
Loading