Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse global stream on start #298

Merged
merged 7 commits into from
Apr 16, 2018
Merged

Browse global stream on start #298

merged 7 commits into from
Apr 16, 2018

Conversation

mostlyobvious
Copy link
Member

  • browser starts on global stream, which by design references all events
  • still allows jumping into particular stream via URL
  • removes troublesome get_all_streams API

Closes #212

#212

It should already give an overview of recent events in the system (as
global stream has them all). It would not suffer from performance issues
of stream browsing. It would still allow jumping into specific stream
via URL, like: http://localhost:8080/#streams/Order%24419 which would go
to Order$419 stream.
It was there solely for browser feature that is no longer.
We no longer browse list of streams.
Item made sense when there was more than one thing to browse. Since we
only have events, rename to remove that friction.
@mostlyobvious
Copy link
Member Author

@fmwr @paneq Please give it a look in the light of #212

@mostlyobvious mostlyobvious changed the title Browse global stream on start. Browse global stream on start Apr 16, 2018
@mostlyobvious mostlyobvious merged commit fad156b into master Apr 16, 2018
@mostlyobvious mostlyobvious deleted the browser-main-screen branch April 16, 2018 14:54
@paneq
Copy link
Member

paneq commented Apr 16, 2018

Spoko!

@mostlyobvious mostlyobvious mentioned this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants