ROM Memory adapter implementation to allow easily adding alternate ROM implementations #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paneq there are 7 mutations locally that need to be killed. Mutant says that it re-inserted the original code and tests failed. However, there is no failure output. Any idea what to do about that? |
|
@paneq or @pawelpacana you guys know how to make sense of the results here? https://circleci.com/gh/RailsEventStore/rails_event_store/2492 Thanks! |
joelvh
force-pushed
the
feature/rom_memory_adapter
branch
from
a2d7685 to
ff5eeed
Compare
…tions and EventRepository
joelvh
force-pushed
the
feature/rom_memory_adapter
branch
from
ff5eeed to
6378cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the ROM Memory adapter as an alternative to the ROM SQL adapter. Tests are structured to test ROM implementations easily. A new ROM adapter simply needs to implement the two relations required.