Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use any background job library to handle async jobs #381

Merged
merged 4 commits into from
Jun 27, 2018
Merged

Allow to use any background job library to handle async jobs #381

merged 4 commits into from
Jun 27, 2018

Conversation

mpraglowski
Copy link
Member

Breaking change: signature of dispatcher's proxy strategy is changed

@mpraglowski mpraglowski self-assigned this Jun 26, 2018
@mpraglowski mpraglowski removed their assignment Jun 26, 2018
mostlyobvious
mostlyobvious reviewed Jun 27, 2018
View reviewed changes
rails_event_store/spec/async_dispatcher_spec.rb
end

class MyAsyncHandler
@@received = nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this and other class variables will make this test brittle

mostlyobvious
mostlyobvious reviewed Jun 27, 2018
View reviewed changes
rails_event_store/lib/rails_event_store/async_dispatcher.rb Outdated
@@ -1,27 +1,25 @@
module RailsEventStore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActiveJobDispatcher is RailsEventStore::, however AsyncDispatcher can be moved to RubyEventStore:: and be used in non-rails scenarios.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still use there AsyncProxyStrategy::AfterCommit which uses ActiveRecord but maybe this should stay in RailsEventStore:: and only AsyncProxyStrategy::Inline should moved with AsyncDispatcher to RubyEventStore::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mostlyobvious mostlyobvious merged commit 1f61303 into RailsEventStore:master Jun 27, 2018
@mpraglowski mpraglowski deleted the to-async branch June 27, 2018 10:40
@paneq
Copy link
Member

paneq commented Jun 27, 2018 •
edited
Loading

Looks good (and I am happy it was merged) except for one thing. async_call is a suboptimal name. Let's figure out something better?

How about

  • scheduler,
  • queuing,
  • enqueuing,
  • enqueue,
  • enqueuer,
  • adapter

?

@paneq
Copy link
Member

paneq commented Jun 27, 2018

@mpraglowski do you plan updating the documentation in a separate PR?

@mostlyobvious
Copy link
Member

async_call is a suboptimal name

scheduler and executor were on my list

@mostlyobvious
Copy link
Member

btw. docs can live in master via toggle

@mpraglowski
Copy link
Member Author

@paneq yep - just after some refactorings mentioned here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostlyobvious mostlyobvious mostlyobvious left review comments

@paneq paneq Awaiting requested review from paneq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpraglowski @paneq @mostlyobvious