Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append_to_stream rename #387

Merged
merged 6 commits into from
Jul 6, 2018
Merged

append_to_stream rename #387

merged 6 commits into from
Jul 6, 2018

Conversation

mpraglowski
Copy link
Member

No description provided.

joelvh
joelvh reviewed Jun 29, 2018
View reviewed changes
railseventstore.org/source/docs/exceptions.html.md.erb Outdated
@@ -34,13 +34,21 @@ If you want to have an event present in multiple streams, you have to link it wi

### RubyEventStore::InvalidExpectedVersion

<% if version_above('0.30.0') %>
Occurs when invalid `exception_version` is passed in `append`, `link_to_stream`, `publish_event` or `publish_events`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was publish rename merged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#377 yes - but I don't want to change docs in this PR - keep it focused on append_to_stream - however this needs update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in docs for #377 are here #378

@paneq
Copy link
Member

paneq commented Jun 30, 2018

@mpraglowski what do you think about persist instead of append ? Imagine we start persisting commands as well without triggering handlers.

@mpraglowski
Copy link
Member Author

Some said:

I don't assume commands must to be stored in the same stream as as events for an object/entity/aggregate.

So why you assume we will use the same method to store events & commands ;)

@paneq
Copy link
Member

paneq commented Jun 30, 2018

So why you assume we will use the same method to store events & commands ;)

I see no reason to have 2 different methods for it. For me it's about persisting a message in both cases.

@mpraglowski
Copy link
Member Author

I'm not convinced that a RubyEventStore::Client is the best place to store commands, why here? Why not some CommandStore? If we will have different data structures, it will have different use cases, looks for me as something that does not belongs here.
Maybe we should have EventStore & CommandStore that will have common part in MessageStore. But that's discussion belongs to #340

@mostlyobvious
Copy link
Member

@mpraglowski would merge but conflicts

@mostlyobvious mostlyobvious merged commit 802d952 into RailsEventStore:master Jul 6, 2018
@mpraglowski mpraglowski deleted the append-rename branch July 6, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelvh joelvh joelvh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpraglowski @paneq @mostlyobvious @joelvh