Make RubyEventStore methods return self instead of ok #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swistak35
force-pushed
the
rl/self-over-ok
branch
from
9ede61d to
6684162
Compare
paneq
reviewed
Aug 1, 2018
| specify 'publish returns :ok when success' do | ||
| expect(client.publish(TestEvent.new)).to eq(:ok) | ||
| specify 'publish returns self when success' do | ||
| expect(client.publish(TestEvent.new)).to eq(client) |
There was a problem hiding this comment.
I usually tested it as client.publish().publish() but that's also fine :)
There was a problem hiding this comment.
hmmm that could be good places to start going with mutant annotations:
specify 'publish returns self when success', mutant: "RubyEventStore::Client#publish" do
which should help with making mutation testing run faster. Do you think you could try that here and in a few other places where you know which method you test.
There was a problem hiding this comment.
@paneq I'm not a fan (yet) of this mutant: keyword, so I will pass on this here. Maybe another good first issue for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #392