Verify behaviour of an AfterCommitAsyncDispatcher when there was raise in some after_commit callback #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that after_commit in one of ActiveRecords has failed
(raised). In such case:
* error is bubbled up after transaction block
* commited! is called with additional argument (with specifics
depending on Rails version)
What it means for us is that:
* transaction is commited, records are saved (and events appended)
thus proceeding with scheduling of handling the event
* AsyncRecord#committed must accept additional arguments to not fail
scheduling in this case
[#183]
mostlyobvious
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that
after_commitcallback in one of ActiveRecords has raised. In such case:depending on Rails version)
What it means for us is that:
thus proceeding with scheduling of handling the event
scheduling in this case
Closes: #183