Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mappers & transformations separated #600

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Mappers & transformations separated #600

merged 1 commit into from
Jun 24, 2019

Conversation

mpraglowski
Copy link
Member

Trying to introduce some structure here, and separation between mappers
& transformations.

Trying to introduce some structure here, and separation between mappers
& transformations.
Copy link
Contributor

@swistak35 swistak35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but I think I don't like the fact that different classes related to encryption end up in different directories different directories; I think I'd put all encryption related into encryption or something like that

@@ -0,0 +1,125 @@
module RubyEventStore
module Mappers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe EncryptionKey and ForgottenData could be here as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for it probably was:

  • no change of already published (released) consts
  • no divergence in class name and its location in filesystem structure

@mostlyobvious mostlyobvious merged commit e5ebf50 into master Jun 24, 2019
@mostlyobvious mostlyobvious deleted the mappers-rename branch June 24, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants