Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Browser minor improvements #727

Merged
merged 23 commits into from
Oct 1, 2020
Merged

[WIP] Browser minor improvements #727

merged 23 commits into from
Oct 1, 2020

Conversation

swistak35
Copy link
Contributor

@swistak35 swistak35 commented Apr 30, 2020 •
edited
Loading

Changes:

  • when loading event, it no longer displays "Not found" on network error / loading time, but more meaningful information instead
  • it does not display "Related streams" at stream view, if default RelatedStreamsQuery is used
  • API now lives under /api, whereas frontend no longer use fragment URLs (so frontend url for an event is now /events/event-uuid instead of #events/event-uuid)

@swistak35 swistak35 changed the title Browser minor improvements [WIP] Browser minor improvements Apr 30, 2020
@swistak35 swistak35 force-pushed the rl/browser-minor-improvements branch from 69d823e to 2dbc48e Compare May 8, 2020 13:34
@mostlyobvious mostlyobvious mentioned this pull request Sep 15, 2020
Open
@swistak35
Put whole api under /api umbrella
8e1cfc9
@swistak35
Use nesting in tests
cbb65ab
@swistak35
Use Routing in rendering the page too
2e2d1f4
@swistak35
Refactoring: Extract method Routing#base_url
3b76e8f
@swistak35
Very spike-ish solution for parsing without fragments
a661e86 
It's all problematic because now we have to know our base url and
substract that base url from the actual url, *sigh*
@swistak35
Don't include excessive slash in the URL
c09cad8
@swistak35
Add possibility to specify mount point
eae18d5 
To easily test the app under /, /res or other URLs
@swistak35
Parse URLs provided to app just after app initialization
e6d50af
@swistak35
Rename ViewStream -> ShowStream
8d0bc86
@swistak35
Distinguish between different HTTP state when displaying Event
9ee9315
@swistak35
Use RemoteResource when fetching causedEvents
3dd8f18
@swistak35
decodeLocation now works with Url, not String
3df0c00
@swistak35
Extract Route tests
d2cad04
@swistak35
Remove dead code
4278249
@swistak35
Extract common method and add tests for URL generation
a4ec1a5
@swistak35
Added more Route tests
7f2851c
@swistak35
Fix browser_integration_spec after changing API url
cdf724f
@swistak35
Add apiUrl to the data passed to frontend
4626006
@swistak35
Base the requests only based on apiUrl
80d3f75
@swistak35
Make it possible to customize backend api_url
949e08a
@swistak35
Use different pagination url
d077238 
JSON API recommends to use `page[...]` params, pagination
/position/direction/count/ was far from json api url structure.
Also, it was broken, from one point of view all of the pagination
arguments were required, from other: we had that [direction, position,
count].compact for which I don't know rationale.
@swistak35
Add spinner for event loading screen
9e28708
@swistak35
Prettify
94937a6
@swistak35 swistak35 force-pushed the rl/browser-minor-improvements branch from 2dbc48e to 94937a6 Compare September 30, 2020 13:14
@mostlyobvious mostlyobvious merged commit f7370c2 into master Oct 1, 2020
@mostlyobvious mostlyobvious deleted the rl/browser-minor-improvements branch October 1, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swistak35 @mostlyobvious