Adds time filtering of events #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InvalidPageStop is very specific error already and does not fit invalid time argument. Side note: move to value objects such as PageStop to ensure valid input and useful message for end user when input is not right.
mostlyobvious
force-pushed
the
add-filtering-by-dates
branch
from
4bd2400 to
a610204
Compare
Mosrt importantly, Time responds to to_time.
We do not extend single example to cover every other case.
AR handles time strings poorly, leading to mysq/sqlite errors on Rails 5.0—5.1.
mostlyobvious
force-pushed
the
add-filtering-by-dates
branch
from
a610204 to
86fa658
Compare
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.