Allow to specify event type resolver for subscriptions #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swistak35
approved these changes
Nov 12, 2020
ruby_event_store/lib/ruby_event_store/spec/subscriptions_lint.rb
Outdated
Show resolved
Hide resolved
mostlyobvious
force-pushed
the
event-type-resolver
branch
from
ad66cd1 to
094e771
Compare
mostlyobvious
referenced
this pull request
Dec 21, 2020
* do not expose subscribers from broker * rely on event type (naming), update method description & simplify implementation
mpraglowski
force-pushed
the
event-type-resolver
branch
from
094e771 to
b020c17
Compare
Make implicit explicit. Type resolver is reponsible for converting event type from anything (class, string, etc) to event type (string preffered here). Default implementation (backward compatible) is just lambda using to_s method to convert event type given as class or string to string.
Event type resolver will be invoked by subscriptions objects in all_for method. No need to use to_s here. That's responsibility of the event type resolver.
mostlyobvious
force-pushed
the
event-type-resolver
branch
from
b020c17 to
e2cafa4
Compare
|
@mpraglowski this needs to cover aggregate_root as well |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make implicit explicit. Type resolver is reponsible
for converting event type from anything (class, string, etc)
to event type (string preffered here).
Default implementation (backward compatible) is just
lambda using to_s method to convert event type
given as class or string to string.