Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ws chat #233

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Feature/ws chat #233

merged 5 commits into from
Jul 21, 2022

Conversation

Rakambda
Copy link
Member

#229 targeting develop

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #233 (cb5df6d) into develop (9e0dbe2) will increase coverage by 0.27%.
The diff coverage is 92.36%.

❗ Current head cb5df6d differs from pull request most recent head c75dda0. Consider uploading reports for the commit c75dda0 to get more accurate results

@@              Coverage Diff              @@
##             develop     #233      +/-   ##
=============================================
+ Coverage      87.43%   87.70%   +0.27%     
- Complexity       735      775      +40     
=============================================
  Files            159      164       +5     
  Lines           2117     2221     +104     
  Branches         150      152       +2     
=============================================
+ Hits            1851     1948      +97     
- Misses           233      236       +3     
- Partials          33       37       +4     
Flag Coverage Δ
unittests-miner 88.35% <92.36%> (+0.24%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ner/miner/api/chat/irc/TwitchIrcEventListener.java 53.84% <ø> (ø)
...iner/miner/api/ws/TwitchPubSubWebSocketClient.java 94.36% <ø> (ø)
...channelpointsminer/miner/factory/MinerFactory.java 100.00% <ø> (ø)
...na/channelpointsminer/miner/util/SleepHandler.java 50.00% <50.00%> (ø)
...lpointsminer/miner/api/chat/TwitchChatFactory.java 80.00% <80.00%> (ø)
...r/miner/api/chat/ws/TwitchChatWebSocketClient.java 87.75% <87.75%> (ø)
...ner/miner/api/chat/ws/TwitchChatWebSocketPool.java 97.67% <97.67%> (ø)
...sminer/miner/api/chat/irc/TwitchIrcChatClient.java 100.00% <100.00%> (ø)
...intsminer/miner/api/chat/irc/TwitchIrcFactory.java 100.00% <100.00%> (ø)
...sminer/miner/api/ws/TwitchPubSubWebSocketPool.java 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Rakambda Rakambda merged commit c47a962 into develop Jul 21, 2022
@Rakambda Rakambda deleted the feature/ws-chat branch July 21, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant