Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database tests #272

Merged
merged 9 commits into from
Sep 4, 2022
Merged

Add database tests #272

merged 9 commits into from
Sep 4, 2022

Conversation

Rakambda
Copy link
Member

@Rakambda Rakambda commented Sep 3, 2022

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Internal change

Description

@Rakambda Rakambda self-assigned this Sep 3, 2022
@Rakambda Rakambda changed the base branch from main to develop September 3, 2022 13:50
@Rakambda Rakambda changed the title Feature/db tests Add database tests Sep 3, 2022
@Rakambda Rakambda marked this pull request as draft September 3, 2022 13:50
@Rakambda Rakambda linked an issue Sep 3, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #272 (8770fa1) into develop (4352dff) will increase coverage by 5.85%.
The diff coverage is 69.23%.

@@              Coverage Diff              @@
##             develop     #272      +/-   ##
=============================================
+ Coverage      83.09%   88.95%   +5.85%     
- Complexity       864      892      +28     
=============================================
  Files            173      173              
  Lines           2644     2652       +8     
  Branches         183      185       +2     
=============================================
+ Hits            2197     2359     +162     
+ Misses           404      244     -160     
- Partials          43       49       +6     
Flag Coverage Δ
unittests-miner 89.51% <69.23%> (+5.96%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nelpointsminer/miner/database/MariaDBDatabase.java 0.00% <0.00%> (ø)
...hannelpointsminer/miner/database/NoOpDatabase.java 7.14% <0.00%> (ø)
...hannelpointsminer/miner/database/BaseDatabase.java 92.62% <94.87%> (+92.00%) ⬆️
...nnelpointsminer/miner/database/SQLiteDatabase.java 100.00% <100.00%> (+100.00%) ⬆️
...channelpointsminer/miner/factory/MinerFactory.java 100.00% <100.00%> (ø)
...intsminer/miner/database/converter/Converters.java 92.85% <0.00%> (+92.85%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda marked this pull request as ready for review September 4, 2022 09:15
@Rakambda Rakambda merged commit bd9b0e4 into develop Sep 4, 2022
@Rakambda Rakambda deleted the feature/db-tests branch September 4, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some DB tests
1 participant