Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown field 'summaries_by_display_type' in update-summary #279

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

Rakambda
Copy link
Member

@Rakambda Rakambda commented Sep 8, 2022

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

  • Bug fix
  • New feature
  • Breaking change

Description

@Rakambda Rakambda added type: 🐛 bug Something isn't working app: ⛏️ miner labels Sep 8, 2022
@Rakambda Rakambda self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #279 (5b5f3f8) into develop (6727656) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop     #279   +/-   ##
==========================================
  Coverage      88.96%   88.96%           
  Complexity       893      893           
==========================================
  Files            173      173           
  Lines           2655     2656    +1     
  Branches         186      186           
==========================================
+ Hits            2362     2363    +1     
  Misses           244      244           
  Partials          49       49           
Flag Coverage Δ
unittests-miner 89.53% <100.00%> (+<0.01%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../data/message/subtype/NotificationDisplayType.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda merged commit 7184f62 into develop Sep 8, 2022
@Rakambda Rakambda deleted the fix/update-summary branch September 8, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant