Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integrity token to GQL requests #286

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Add integrity token to GQL requests #286

merged 3 commits into from
Sep 14, 2022

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Internal change

Description

@Rakambda Rakambda self-assigned this Sep 14, 2022
@Rakambda Rakambda linked an issue Sep 14, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #286 (2d7f609) into develop (b87387e) will increase coverage by 0.12%.
The diff coverage is 97.77%.

@@              Coverage Diff              @@
##             develop     #286      +/-   ##
=============================================
+ Coverage      88.96%   89.09%   +0.12%     
- Complexity       893      904      +11     
=============================================
  Files            173      175       +2     
  Lines           2656     2687      +31     
  Branches         186      189       +3     
=============================================
+ Hits            2363     2394      +31     
  Misses           244      244              
  Partials          49       49              
Flag Coverage Δ
unittests-miner 89.65% <97.77%> (+0.12%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ana/channelpointsminer/miner/MinerApplication.java 0.00% <0.00%> (ø)
...inana/channelpointsminer/miner/api/gql/GQLApi.java 97.18% <100.00%> (+1.18%) ⬆️
.../miner/api/passport/exceptions/IntegrityError.java 100.00% <100.00%> (ø)
...r/util/json/MillisecondsTimestampDeserializer.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda merged commit 6a23095 into develop Sep 14, 2022
@Rakambda Rakambda deleted the feature/integrity branch September 14, 2022 21:04
@Rakambda Rakambda linked an issue Sep 15, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GQL API and Passport API requests now require an integrity token
1 participant