Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity again #289

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Integrity again #289

merged 2 commits into from
Sep 15, 2022

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Internal change

Description

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #289 (33c424d) into develop (9b465e1) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop     #289      +/-   ##
=============================================
+ Coverage      89.09%   89.12%   +0.03%     
- Complexity       904      905       +1     
=============================================
  Files            175      174       -1     
  Lines           2687     2695       +8     
  Branches         189      189              
=============================================
+ Hits            2394     2402       +8     
  Misses           244      244              
  Partials          49       49              
Flag Coverage Δ
unittests-miner 89.68% <100.00%> (+0.03%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...inana/channelpointsminer/miner/api/gql/GQLApi.java 97.43% <100.00%> (+0.25%) ⬆️
.../miner/api/ws/data/request/ListenTopicRequest.java 100.00% <100.00%> (ø)
...iner/api/ws/data/request/UnlistenTopicRequest.java 100.00% <100.00%> (ø)
...nelpointsminer/miner/prediction/bet/BetPlacer.java 97.87% <100.00%> (ø)
...ana/channelpointsminer/miner/util/CommonUtils.java 58.33% <100.00%> (+13.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda merged commit 14e67f4 into develop Sep 15, 2022
@Rakambda Rakambda deleted the feature/integrity branch September 15, 2022 08:53
@Rakambda Rakambda linked an issue Sep 15, 2022 that may be closed by this pull request
@Rakambda Rakambda linked an issue Sep 15, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GQL API and Passport API requests now require an integrity token
1 participant