Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire events when moment/drop is actually claimed + get Client-Version value dynamically #292

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Description

@Rakambda Rakambda self-assigned this Sep 16, 2022
@Rakambda Rakambda changed the title Feat/improvments Fire events when moment/drop is actually claimed + get Client-Version value dynamically Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #292 (5777cfa) into develop (58d3035) will increase coverage by 0.07%.
The diff coverage is 96.05%.

@@              Coverage Diff              @@
##             develop     #292      +/-   ##
=============================================
+ Coverage      89.25%   89.32%   +0.07%     
- Complexity       907      929      +22     
=============================================
  Files            174      176       +2     
  Lines           2707     2753      +46     
  Branches         189      194       +5     
=============================================
+ Hits            2416     2459      +43     
- Misses           242      244       +2     
- Partials          49       50       +1     
Flag Coverage Δ
unittests-miner 89.87% <96.05%> (+0.06%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...annelpointsminer/miner/runnable/SyncInventory.java 90.24% <72.72%> (-7.06%) ⬇️
...inana/channelpointsminer/miner/api/gql/GQLApi.java 98.00% <100.00%> (+0.53%) ⬆️
...intsminer/miner/event/impl/ClaimedMomentEvent.java 100.00% <100.00%> (ø)
...elpointsminer/miner/event/impl/DropClaimEvent.java 100.00% <100.00%> (ø)
...pointsminer/miner/event/impl/DropClaimedEvent.java 100.00% <100.00%> (ø)
...a/channelpointsminer/miner/factory/ApiFactory.java 100.00% <100.00%> (ø)
...lpointsminer/miner/handler/ClaimMomentHandler.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda merged commit 5cca64d into develop Sep 16, 2022
@Rakambda Rakambda deleted the feat/improvments branch September 16, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant