Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth & integrity through Selenium #309

Merged
merged 21 commits into from
Oct 8, 2022
Merged

Auth & integrity through Selenium #309

merged 21 commits into from
Oct 8, 2022

Conversation

Rakambda
Copy link
Member

@Rakambda Rakambda commented Oct 6, 2022

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

New Feature

Description

  • Maybe change config format, move user/pass/2fa to it's own field, and allow either it or browser

@Rakambda Rakambda self-assigned this Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #309 (c093c95) into develop (a6d430b) will decrease coverage by 3.15%.
The diff coverage is 45.28%.

@@              Coverage Diff              @@
##             develop     #309      +/-   ##
=============================================
- Coverage      89.48%   86.33%   -3.16%     
- Complexity       948      982      +34     
=============================================
  Files            181      189       +8     
  Lines           2805     3007     +202     
  Branches         199      210      +11     
=============================================
+ Hits            2510     2596      +86     
- Misses           244      358     +114     
- Partials          51       53       +2     
Flag Coverage Δ
unittests-miner 86.78% <45.28%> (-3.24%) ⬇️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../api/gql/integrity/http/HttpIntegrityProvider.java 100.00% <ø> (ø)
...nelpointsminer/miner/api/passport/TwitchLogin.java 100.00% <ø> (ø)
...a/channelpointsminer/miner/browser/CookieData.java 0.00% <0.00%> (ø)
...prediction/bet/action/StealthPredictionAction.java 100.00% <ø> (ø)
...er/miner/prediction/bet/amount/ConstantAmount.java 100.00% <ø> (ø)
.../miner/prediction/bet/amount/PercentageAmount.java 100.00% <ø> (ø)
...ion/bet/outcome/BiggestPredictorOutcomePicker.java 100.00% <ø> (ø)
...ediction/bet/outcome/LeastPointsOutcomePicker.java 100.00% <ø> (ø)
...rediction/bet/outcome/LeastUsersOutcomePicker.java 100.00% <ø> (ø)
...rediction/bet/outcome/MostPointsOutcomePicker.java 100.00% <ø> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda linked an issue Oct 7, 2022 that may be closed by this pull request
@Rakambda Rakambda mentioned this pull request Oct 7, 2022
@Rakambda Rakambda changed the title Auth & tokens through Selenium Auth & integrity through Selenium Oct 8, 2022
@Rakambda Rakambda merged commit 17d3b12 into develop Oct 8, 2022
@Rakambda Rakambda deleted the integrity-selenium branch October 8, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GQL API and Passport API requests now require an integrity token
1 participant