Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide a cookies file for BROWSER login method #314

Merged
merged 10 commits into from
Oct 10, 2022

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

New Feature

Description

@Rakambda Rakambda self-assigned this Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #314 (e08157f) into develop (93a9102) will decrease coverage by 0.14%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             develop     #314      +/-   ##
=============================================
- Coverage      86.13%   85.98%   -0.15%     
- Complexity       982      988       +6     
=============================================
  Files            189      190       +1     
  Lines           3014     3032      +18     
  Branches         211      215       +4     
=============================================
+ Hits            2596     2607      +11     
- Misses           365      372       +7     
  Partials          53       53              
Flag Coverage Δ
unittests-miner 86.42% <60.00%> (-0.16%) ⬇️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...elpointsminer/miner/browser/BrowserController.java 2.32% <0.00%> (-0.46%) ⬇️
...a/channelpointsminer/miner/browser/CookieData.java 0.00% <ø> (ø)
...miner/api/passport/browser/BrowserPassportApi.java 88.88% <100.00%> (+0.65%) ⬆️
...ksrinana/channelpointsminer/miner/miner/Miner.java 96.52% <100.00%> (+0.04%) ⬆️
...er/miner/util/json/CookieSameSiteDeserializer.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda merged commit f84c521 into develop Oct 10, 2022
@Rakambda Rakambda deleted the feature/cookies-file branch October 10, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant