Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android TV login #379

Merged
merged 6 commits into from
Dec 24, 2022
Merged

Android TV login #379

merged 6 commits into from
Dec 24, 2022

Conversation

Rakambda
Copy link
Member

@Rakambda Rakambda commented Dec 21, 2022

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
    • TVLoginProvider
    • Config parsing
  • Corresponding changes made to the documentation (README.adoc)
    • Update example files

Type of change

New Feature

Description

Add a new login method using the Android TV app, thanks to @aeongdesu

@Rakambda Rakambda self-assigned this Dec 21, 2022
@Rakambda Rakambda marked this pull request as draft December 21, 2022 17:23
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #379 (ebc8244) into develop (e4645ef) will increase coverage by 0.14%.
The diff coverage is 91.81%.

@@              Coverage Diff              @@
##             develop     #379      +/-   ##
=============================================
+ Coverage      86.02%   86.17%   +0.14%     
- Complexity      1010     1030      +20     
=============================================
  Files            194      199       +5     
  Lines           3142     3225      +83     
  Branches         225      236      +11     
=============================================
+ Hits            2703     2779      +76     
- Misses           384      389       +5     
- Partials          55       57       +2     
Flag Coverage Δ
unittests-miner 86.59% <91.81%> (+0.13%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ner/api/passport/browser/BrowserLoginProvider.java 90.00% <ø> (ø)
...ntsminer/miner/config/login/MobileLoginMethod.java 0.00% <ø> (ø)
...lpointsminer/miner/config/login/TvLoginMethod.java 0.00% <0.00%> (ø)
...rakambda/channelpointsminer/miner/miner/Miner.java 96.52% <ø> (ø)
...ql/integrity/browser/BrowserIntegrityProvider.java 95.83% <50.00%> (ø)
...er/api/gql/integrity/http/NoIntegrityProvider.java 66.66% <66.66%> (ø)
...r/miner/api/passport/oauth/OauthLoginProvider.java 90.16% <90.16%> (ø)
...a/channelpointsminer/miner/api/gql/gql/GQLApi.java 100.00% <100.00%> (ø)
.../api/gql/integrity/http/HttpIntegrityProvider.java 100.00% <100.00%> (ø)
...pi/gql/integrity/http/MobileIntegrityProvider.java 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rakambda Rakambda marked this pull request as ready for review December 22, 2022 14:30
@Rakambda Rakambda merged commit 3c40772 into develop Dec 24, 2022
@Rakambda Rakambda deleted the feature/tv-login branch December 24, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant