Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change value type for reward type #748

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Change value type for reward type #748

merged 3 commits into from
Apr 10, 2024

Conversation

Rakambda
Copy link
Member

@Rakambda Rakambda commented Apr 10, 2024

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Description

@Rakambda Rakambda added the type: 🐛 bug Something isn't working label Apr 10, 2024
@Rakambda Rakambda self-assigned this Apr 10, 2024
@Rakambda Rakambda requested a review from couchoud-t as a code owner April 10, 2024 07:46
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (1f6f1d3) to head (11b0a9d).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #748      +/-   ##
=============================================
- Coverage      85.04%   85.02%   -0.03%     
+ Complexity      1060     1059       -1     
=============================================
  Files            206      205       -1     
  Lines           3371     3365       -6     
  Branches         251      251              
=============================================
- Hits            2867     2861       -6     
  Misses           448      448              
  Partials          56       56              
Flag Coverage Δ
unittests-miner 85.40% <ø> (-0.03%) ⬇️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rakambda Rakambda merged commit 5024675 into develop Apr 10, 2024
11 of 12 checks passed
@Rakambda Rakambda deleted the fix/reward-type branch April 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants