Add read-all-notifications ws type to avoid errors
#780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
|
Test added. Sorry about that, I missed that! I think I did it right? |
Rakambda
requested changes
May 21, 2024
...java/fr/rakambda/channelpointsminer/miner/api/ws/TwitchPubSubWebSocketClientMessageTest.java
Outdated
Show resolved
Hide resolved
…s/TwitchPubSubWebSocketClientMessageTest.java
Rakambda
approved these changes
May 21, 2024
Rakambda
changed the title
read-all-notifications ws type to avoid errors
Rakambda
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Checklist
Type of change
"Bug fix"
Description
This PR adds support for a
read-all-notificationswebsocket message that is sent/received when clicking the envelope icon in the notifications menu to mark any unread notifications as read. Previously this would cause an exception for an unhandled message type. This change at the very least suppresses this.