Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve M3U8 request by performing head request #802

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Internal change

Description

Using head request will prevent the body from being downloaded requiring less network IO

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.66%. Comparing base (3dbbbce) to head (1a95d9c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #802   +/-   ##
==========================================
  Coverage      85.66%   85.66%           
  Complexity      1104     1104           
==========================================
  Files            200      200           
  Lines           3447     3447           
  Branches         260      260           
==========================================
  Hits            2953     2953           
  Misses           441      441           
  Partials          53       53           
Flag Coverage Δ
unittests-miner 86.05% <100.00%> (ø)
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rakambda Rakambda merged commit 27980e9 into develop Jun 18, 2024
12 checks passed
@Rakambda Rakambda deleted the feature/request-head branch June 18, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant