Split channel point farming and drop farming into separate behaviours #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbink
commented
Jul 20, 2024
miner/src/test/java/fr/rakambda/channelpointsminer/miner/runnable/SendMinutesWatchedTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Checklist
Type of change
New feature and breaking change
Nothing changes in configuration, but if a user wants to farm channel points specifically for channels with drops enabled, this will break their workflow. I don't think anyone would want to do that but you never know. To me it is more logical to just get drops, and then, if the priority is high enough based on other things, get channel points there as well, or on a totally different channel.
Description
New logic:
Can effectively "watch" 3 different streams, giving channel points on 2 according to ALL priority settings except for DropsPriority, and one solely according to DropsPriority.