-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Main Thread Checker #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
apple-main-thread-checker
branch
2 times, most recently
from
December 7, 2023 03:17
0984e25
to
e06f191
Compare
RalfJung
reviewed
Dec 18, 2023
madsmtm
force-pushed
the
apple-main-thread-checker
branch
from
December 22, 2023 21:51
e06f191
to
2cfb160
Compare
RalfJung
reviewed
Dec 23, 2023
RalfJung
reviewed
Dec 26, 2023
RalfJung
reviewed
Dec 26, 2023
RalfJung
reviewed
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! There's still one point I am a bit confused about but I am also fine leaving this as-is. Please squash the commits.
madsmtm
force-pushed
the
apple-main-thread-checker
branch
from
January 14, 2024 23:19
1597e04
to
0506784
Compare
RalfJung
reviewed
Jan 15, 2024
Thanks for your attention to detail! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22