Allow patterned polylines #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
haysmike
commented
May 17, 2024
haysmike
commented
haysmike
commented
May 17, 2024
Comment on lines
44
to
53
| linePatternId?.let { | ||
| val id = it.toString() | ||
| if (mapApplier.style.getImage(id) == null) { | ||
| val vectorDrawable = context.getDrawable(it) as? VectorDrawable | ||
| if (vectorDrawable == null) { | ||
| mapApplier.style.addImage( | ||
| id, | ||
| ImageBitmap.imageResource(it).asAndroidBitmap() | ||
| ) | ||
| } else { | ||
| vectorDrawable.let { drawable -> | ||
| mapApplier.style.addImage(id, drawable) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is basically copied from the Symbol implementation. Should we extract? I kind of prefer the impl here since it uses the refined inner variable instead of the nullable outer variable, but open to feedback.
There was a problem hiding this comment.
Let's pull out a helper
There was a problem hiding this comment.
And add ktfmtFormat
haysmike
commented
May 17, 2024
|
Those corners look terrible 😬 |
haysmike
force-pushed
the
haysmike/patterned-polylines
branch
from
9b75cfa to
e2ed403
Compare
haysmike
commented
Sep 10, 2024
|
Bump version to 0.1.1 |
ianthetechie
approved these changes
Sep 24, 2024
ianthetechie
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.