Directional drivers analysis using Pearson's correlation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 1 1
Lines 46 46
=======================================
Hits 44 44
Misses 2 2Continue to review full report at Codecov.
|
xulaus
requested changes
Apr 7, 2017
|
|
||
| series = Kruskals.Kruskals(ndarr, arr).driver_score_to_series(True) | ||
|
|
||
| assert (series.values < 0).any() |
There was a problem hiding this comment.
newline at end of file please.
tests/test_kruskals.py
Outdated
| assert (series.index.values == ind_cols).all() | ||
|
|
||
| def test_direction_on_directional_drivers_analysis(): | ||
| """ Test percentage is calculated correctly """ |
There was a problem hiding this comment.
This comment is abiguious as the test is really "is directionality applied"
tests/test_kruskals.py
Outdated
| @@ -79,3 +79,42 @@ def test_series_output(): | |||
| assert np.array_equal(np.round(series.values, decimals=5), exp_driver_score) | |||
| assert series.name == 'score' | |||
| assert series.index.name == 'driver' | |||
|
|
|||
| def test_ivars_sub_into_series(): | |||
| """ Test percentage is calculated correctly """ | |||
xulaus
approved these changes
Apr 7, 2017
Rambatino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.