Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for pre-releases and semantic versioning (PowerShell Gallery) #111

Merged
merged 6 commits into from
Jun 28, 2020

Conversation

raandree
Copy link
Contributor

This fixes #68.

The code of System.Management.Automation.SemanticVersion has been taken from PowerShell 7 and slightly modified to run in PowerShell 5.

Setting Pester version to 4.10.1 as the tests are not working with Pester 5.

@raandree
Copy link
Contributor Author

One thing just came to my mind. This is a braking change that prevents working with 4-digit version numbers. I can do a TryPrase to identify the kind of version we are dealing with and cast either to System.Version or S.M.A.SemanticVersion. Let's wait with the merge.

@raandree raandree marked this pull request as draft June 25, 2020 22:50
@raandree raandree marked this pull request as ready for review June 26, 2020 22:52
@raandree
Copy link
Contributor Author

@RamblingCookieMonster, I have added compatibility for versions and semantic versions in 'PSGalleryModule.ps1'. I have added tests as well.

@RamblingCookieMonster
Copy link
Owner

On a quick pass this lgtm, and looks like error handling will make it a non-breaking change (you had mentioned this above)? If it's working for you, I'm good to merge!

@raandree
Copy link
Contributor Author

Have just tested with the DscWorkshop all works as expected. Without adding a prelease version and / or using latest and parameter 'AllowPrerelease', the behavior does not change and nothing breaks.

@RamblingCookieMonster RamblingCookieMonster merged commit effcd8a into RamblingCookieMonster:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pre-Release versions
2 participants