Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add debug logs for CreateNamespaceAndAddAnnotation and deleteNamespace #1825

Open
parikshithb opened this issue Feb 13, 2025 · 1 comment · May be fixed by #1840
Open

e2e: add debug logs for CreateNamespaceAndAddAnnotation and deleteNamespace #1825

parikshithb opened this issue Feb 13, 2025 · 1 comment · May be fixed by #1840
Assignees
Labels
test Testing related issue

Comments

@parikshithb
Copy link
Member

parikshithb commented Feb 13, 2025

The function CreateNamespaceAndAddAnnotation and its sub-functions CreateNamespace, addNamespaceAnnotationForVolSync currently lack DEBUG-level logging. So need to add debug logs.

Task:

  • Debug log after namespace creation (in CreateNamespace)
  • Debug log after adding namespace annotations (in addNamespaceAnnotationForVolSync)
  • Update info to debug log for namespace deletion (in DeleteNamespace)
  • Debug log after creating and annotating in CreateNamespaceAndAddAnnotation.
    example: log.Debugf("Created and annotated namespace "%s" in DRClusters", namespace)
  • Verify logs by running e2e tests
@parikshithb parikshithb self-assigned this Feb 13, 2025
@parikshithb parikshithb added the test Testing related issue label Feb 13, 2025
@nirs
Copy link
Member

nirs commented Feb 13, 2025

  • Debug log after creating and annotating in CreateNamespaceAndAddAnnotation.
    example: log.Debugf("Created and annotated namespace "%s" in DRClusters", namespace)

This log is not needed since we will have separate logs for creating and annotating. We want to log in the basic operations so we don't need to think about logging. Every operation is automatically logged by the lower level calls with zero maintenance.

@parikshithb parikshithb changed the title e2e: add debug logs for CreateNamespaceAndAddAnnotation e2e: add debug logs for CreateNamespaceAndAddAnnotation and deleteNamespace Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants