Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add debug logs for namespace related util functions #1840

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

parikshithb
Copy link
Member

@parikshithb parikshithb commented Feb 18, 2025

Changes:

  • Added debug log after namespace creation
  • Added debug log after creating namespace annotations and private constant for the annotation
  • Updated info to debug log in DeleteNamespace

Fixes: #1825

@nirs
Copy link
Member

nirs commented Feb 18, 2025

@parikshithb you can rebase on #1839 to make ci pass instead of waiting until it is merged.

Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see suggestion for new comment.

Can you share the log before/after this change?

@parikshithb
Copy link
Member Author

Looks good, see suggestion for new comment.

Can you share the log before/after this change?

  1. Before there was no logs for create/annotate namespace.
    After adding debug logs for create/annotate namespace:
2025-02-18T22:48:56.732+0530	DEBUG	util/namespace.go:38	Created namespace "e2e-subscr-deploy-rbd-busybox"
2025-02-18T22:48:56.788+0530	DEBUG	util/namespace.go:124	Annotated namespace "e2e-subscr-deploy-rbd-busybox" with "volsync.backube/privileged-movers: true"
2025-02-18T22:48:56.801+0530	DEBUG	util/namespace.go:35	Namespace "e2e-subscr-deploy-rbd-busybox" already exist
2025-02-18T22:48:56.801+0530	DEBUG	util/namespace.go:38	Created namespace "e2e-subscr-deploy-rbd-busybox"
2025-02-18T22:48:56.819+0530	DEBUG	util/namespace.go:124	Annotated namespace "e2e-subscr-deploy-rbd-busybox" with "volsync.backube/privileged-movers: true"
  1. Moved from info to debug for deleteNamespace:
2025-02-18T22:56:02.197+0530	DEBUG	disapp-deploy-rbd-busybox	util/namespace.go:61	Waiting until namespace "e2e-disapp-deploy-rbd-busybox" is deleted
2025-02-18T22:56:10.277+0530	DEBUG	disapp-deploy-rbd-busybox	util/namespace.go:72	Namespace "e2e-disapp-deploy-rbd-busybox" deleted

@nirs
Copy link
Member

nirs commented Feb 19, 2025

e2e failed with new random failure:

2025-02-19T13:10:40.045+0530	ERROR	subscr-deploy-rbd-busybox	Failed to failover workload: drpc "subscr-deploy-rbd-busybox" status is not "FailedOver" yet before timeout, fail

@parikshithb
Copy link
Member Author

e2e failed with new random failure:

2025-02-19T13:10:40.045+0530	ERROR	subscr-deploy-rbd-busybox	Failed to failover workload: drpc "subscr-deploy-rbd-busybox" status is not "FailedOver" yet before timeout, fail

Failed again, this time during appset relocate:

2025-02-19T20:56:20.399+0530	ERROR	appset-deploy-cephfs-busybox	Failed to relocate workload: drpc "appset-deploy-cephfs-busybox" status is not "Relocated" yet before timeout, fail

Will rebase and push.

-Add debug log after namespace creation
-Add debug log after adding namespace annotations
 and a private constant for the volsync namespace annotation
-Update info to debug log in DeleteNamespace

Signed-off-by: Parikshith <[email protected]>
@nirs
Copy link
Member

nirs commented Feb 19, 2025

Accessing github from the e2e lab is very flaky now, and not related to change.

@nirs nirs merged commit 6529e69 into RamenDR:main Feb 19, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e: add debug logs for CreateNamespaceAndAddAnnotation and deleteNamespace
2 participants