Add drenv integration tests using podman driver #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShyamsundarR
approved these changes
Jan 4, 2023
nirs
force-pushed
the
example-podman
branch
11 times, most recently
from
900b8f7 to
b2a0e50
Compare
nirs
changed the title
nirs
commented
Jan 4, 2023
| curl -LO https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 | ||
| sudo install minikube-linux-amd64 /usr/local/bin/minikube | ||
| minikube version | ||
| mkdir "$HOME/.minikube/profiles" |
There was a problem hiding this comment.
This is a workaround for minikube bug, will report it later.
There was a problem hiding this comment.
Minikube bug: kubernetes/minikube#15593
nirs
force-pushed
the
example-podman
branch
2 times, most recently
from
dda4592 to
88c987d
Compare
|
Coverage report before this change: Coverage report with this change: |
Instead of hard coding the "kvm2" driver. This will allow creating clusters using different drivers. One interesting case is the example deployment that does not have any reason to use virtual machines. Another interesting cases is the hub clusters which should work with podman driver. Part-of: RamenDR#677 Signed-off-by: Nir Soffer <[email protected]>
If not set, let minikube pick a container runtime instead of defaulting to `containerd`. This is more consistent with other options. Part-of: RamenDR#677 Signed-off-by: Nir Soffer <[email protected]>
The example deployment does need virtual machine. With this change we may be able to start it in github actions. Use `cri-o` runtime, recommended by minikube docs when using `podman` driver[1]. [1] https://minikube.sigs.k8s.io/docs/drivers/podman/ Part-of: RamenDR#677 Signed-off-by: Nir Soffer <[email protected]>
Add a minimal test environment for running system tests on github actions. The environment is using one tiny cluster to make the test less likely to fail in constrained CI setup. Add minikube and kubectl to the drenv test job in github to allow running the new environment during the tests. Part-of: RamenDR#677 Signed-off-by: Nir Soffer <[email protected]>
Add a reusable `tmpenv` fixture, running the test environment during a test session. Using the live test cluster we run integration tests for commands like kubectl. Part-of: RamenDR#677 Signed-off-by: Nir Soffer <[email protected]>
Add integration tests for the kubectl module, using the tmpenv fixture. Part-of: RamenDR#677 Signed-off-by: Nir Soffer <[email protected]>
First enable coverage for child processes, so we get coverage report
from the drenv tool and from script run by the drenv tool. This is a bit
tricky, requiring enabling coverage for child process using a .pth file
and using coverage parallel mode, combining output from multiple
processes.
With this change we report now all code running during the tests:
$ make coverage
python3 -m coverage report
Name Stmts Miss Cover
-----------------------------------------
drenv/__init__.py 77 48 38%
drenv/__main__.py 109 23 79%
drenv/clusteradm.py 41 41 0%
drenv/commands.py 93 2 98%
drenv/envfile.py 80 0 100%
drenv/kubectl.py 31 0 100%
-----------------------------------------
TOTAL 431 114 74%
Part-of: RamenDR#677
Signed-off-by: Nir Soffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container_runtimeto minikube defaultThe test fixture is using the drenv tool to start and stop the environment
covering most of the code in the tool.
Fixes #677