-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noise channel can glitch out when getting on a bike #837
Labels
Comments
ariscop
added a commit
to ariscop/polishedcrystal
that referenced
this issue
Mar 28, 2023
...i think
ariscop
added a commit
to ariscop/polishedcrystal
that referenced
this issue
Mar 28, 2023
...i think
Still not entirely clear what happens but setting NOTE_REST (16afa85 ) seems to make it behave With that set, UpdateChannels actually makes it to .ch4_rest and clears the currently playing note, otherwise it jumps to .ch4_noise_sampling and writes garbage to the sound regs instead |
Merged
itsdarsh
pushed a commit
that referenced
this issue
May 17, 2023
* Remove useless rNR52 writes Lower 4 bits are read-only, and its attempting to duplicate what wSoundOutput already does * Misc changes bc isn't in use during InitSound Moved a comment SOUND_CHANNEL_ON doesnt need to be reset before ChannelInit * Don't count rest notes as noise hits * Fixes #837 ...i think * Don't call ReloadWaveform from the music player Does not actually work. Writes are ignored since the dac is on * Change waveform loading for audio channel 3 Only reloads as needed now to avoid turning off the dac Also doesn't bother writing rNR31 as its value is ignored anyway * Combine DutyCycle and SFXDutyCycle Has the neat side effect of making duty cycle patterns visible in the music player * duty_cycle changes in hgss/ceruleancity Removes some redundant commands and restores dummied out duty_cycle_pattern calls * Apply mono/stereo option once when writing rNR51 Removes a few places mono/stereo take different code paths, and allows changing between them without restarting the music
nickjwilde
pushed a commit
to nickjwilde/polishedcrystal
that referenced
this issue
Jul 7, 2023
* Remove useless rNR52 writes Lower 4 bits are read-only, and its attempting to duplicate what wSoundOutput already does * Misc changes bc isn't in use during InitSound Moved a comment SOUND_CHANNEL_ON doesnt need to be reset before ChannelInit * Don't count rest notes as noise hits * Fixes Rangi42#837 ...i think * Don't call ReloadWaveform from the music player Does not actually work. Writes are ignored since the dac is on * Change waveform loading for audio channel 3 Only reloads as needed now to avoid turning off the dac Also doesn't bother writing rNR31 as its value is ignored anyway * Combine DutyCycle and SFXDutyCycle Has the neat side effect of making duty cycle patterns visible in the music player * duty_cycle changes in hgss/ceruleancity Removes some redundant commands and restores dummied out duty_cycle_pattern calls * Apply mono/stereo option once when writing rNR51 Removes a few places mono/stereo take different code paths, and allows changing between them without restarting the music
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This can be triggered somewhat reliably in violet city with the bike on select. hit select during the group two kicks, after the first snare
Whatever noise note was playing will continue into the bicycle music, the snare for example can be heard somewhat easily, but is most apparent with Kick1 as its first note has a flat volume envelope, and continues to play until another note replaces it
Vanilla crystal avoids this issue by playing MUSIC_NONE for one frame before starting the bike music
The following also works around the issue but i've yet to find the root cause
The text was updated successfully, but these errors were encountered: