Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Interaction Callback Resource #9957

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented Oct 4, 2024

Summary

This adds support for the Interaction Callback Resource returned by any Interaction.response method call by using a new parameter named with_response.
This also adds the poll kwarg to Interaction.edit_original_response.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Contributor

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs that go beyond intended scope generally aren't accepted, what I mean by this is that the addition of poll to Interaction.edit_original_response should be it's own PR to maintain commit tree integrity.

Other than that, some things to correct.

discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
@DA-344 DA-344 marked this pull request as ready for review January 20, 2025 17:10
@Rapptz Rapptz added the needs review This PR will be reviewed in the future label Jan 21, 2025
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR will be reviewed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants