Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy var annotated #10956

Merged
merged 13 commits into from
Mar 4, 2022
Merged

Fix mypy var annotated #10956

merged 13 commits into from
Mar 4, 2022

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Mar 1, 2022 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb requested a review from a team March 1, 2022 15:32
@m-vdb m-vdb requested a review from a team as a code owner March 1, 2022 15:32
@m-vdb m-vdb requested review from kedz, ancalita, a team and ka-bu and removed request for a team, kedz, ancalita and ka-bu March 1, 2022 15:32
ka-bu
ka-bu reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@ka-bu ka-bu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 so happy to see more annotations. Just wondering about that prediction_source case in rule_policy (see comments). Otherwise LGTM

rasa/core/policies/rule_policy.py Show resolved Hide resolved
rasa/core/training/training.py Outdated Show resolved Hide resolved
rasa/engine/storage/local_model_storage.py Show resolved Hide resolved
@m-vdb m-vdb requested a review from ancalita March 2, 2022 15:07
@m-vdb
Copy link
Collaborator Author

m-vdb commented Mar 2, 2022

@ancalita we can wait for your PR to be merged for your review here 👍🏻

@m-vdb m-vdb requested a review from ka-bu March 3, 2022 08:56
ancalita
ancalita approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

rasa/core/migrate.py Show resolved Hide resolved
@m-vdb m-vdb enabled auto-merge March 3, 2022 16:38
@m-vdb m-vdb disabled auto-merge March 3, 2022 16:39
@m-vdb m-vdb enabled auto-merge March 3, 2022 16:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

🚀 A preview of the docs have been deployed at the following URL: https://10956--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@m-vdb m-vdb merged commit d86c672 into main Mar 4, 2022
@m-vdb m-vdb deleted the fix-mypy-var-annotated branch March 4, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ka-bu ka-bu ka-bu approved these changes

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable mypy var-annotated error code
3 participants
@m-vdb @ka-bu @ancalita