Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from past.builtins import basestring
causesDeprecationWarning
PythonCharmers/python-future#551
I believe this alternative using
six
should behave identically.On python3
past.builtins.basestring
is equivalent to(bytes, str)
:https://github.com/PythonCharmers/python-future/blob/80523f383fbba1c6de0551e19d0277e73e69573c/src/past/types/basestring.py#L26
On python2, it is the built in
basestring
:https://github.com/PythonCharmers/python-future/blob/80523f383fbba1c6de0551e19d0277e73e69573c/src/past/builtins/__init__.py#L52
six.string_types
is either(basestring, )
or(str, )
:https://six.readthedocs.io/#six.string_types
six.binary_type
is eitherstr
orbytes
:https://six.readthedocs.io/#six.binary_type