Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More background types #219

Merged
merged 4 commits into from
May 30, 2021
Merged

More background types #219

merged 4 commits into from
May 30, 2021

Conversation

Rio6
Copy link
Collaborator

@Rio6 Rio6 commented May 30, 2021

Description

Adds the following options:

  • --fill -F scale background image to fill displays while maintaining aspect ratio
  • --max -M scale background image to fill displays while maintaining aspect ratio, without clipping
  • --scale -L scale background image to fill displays without maintaining aspect ratio

I also cleaned up the code for --centered a bit, making it reuse xr_resolutions instead of querying randr again.

Screenshots/screencaps

Following images shows all the possible background types (black lines show the display boundaries).

Centered:
centered

Tiling
tiling

Fill
fill

Max
max

Scale
scale

Release notes

Notes: New background image options --max, --fill, and --scale.

@Rio6 Rio6 marked this pull request as ready for review May 30, 2021 06:14
@Rio6 Rio6 force-pushed the more-bg-types branch from f808b2c to c50a1a2 Compare May 30, 2021 06:15
Copy link
Owner

@Raymo111 Raymo111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good job rio

@Raymo111 Raymo111 merged commit e29a2d6 into Raymo111:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants