feat: refactor reminder email service to use nodemailer instead of AWS SES #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericbolikowski
approved these changes
Jan 27, 2025
katamatata
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Thank you, @helloanil. I left a couple of comments. Otherwise, it looks good to me.
| console.log('Email sent successfully') | ||
| } catch (err) { | ||
| console.error('Error sending email:', err) | ||
| } |
There was a problem hiding this comment.
The params and the try ... catch code repeat in multiple places. It would be nice to extract this logic into a helper method at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Github issue does this PR relate to? Insert link.
What should the reviewer know?