Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codecs-unlock patch and update Music patches to 5.14.53 #181

Closed
wants to merge 4 commits into from
Closed

fix: codecs-unlock patch and update Music patches to 5.14.53 #181

wants to merge 4 commits into from

Conversation

ponces
Copy link

@ponces ponces commented Jul 14, 2022

It's working now 👍

Screenshot_20220714-231528_Pixel Launcher

@oSumAtrIX
Copy link
Member

Have you confirmed with multiple videos?

@ponces
Copy link
Author

ponces commented Jul 15, 2022

Have you confirmed with multiple videos?

One or two did not have a better codec available but I believe this patch depends on the video/audio and device as its author stated in the description...
https://user-images.githubusercontent.com/4687488/179216275-628776b0-e4dc-4b28-8728-e9f735b37b91.mp4

@ponces
Copy link
Author

ponces commented Jul 15, 2022

I'll make a final push to also update the version from the ads patch ok?
Thanks!

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jul 15, 2022

Sure. Do not force push, use a proper conventional commit message

@ponces
Copy link
Author

ponces commented Jul 15, 2022

I'm not sure if this is mergeable as it is as I had to include the music-video-ads patch as I didn't have it on this branch.
If not, then you can close this and i'll open a new PR with a clean commit history...

@oSumAtrIX
Copy link
Member

Sure, thanks.

@oSumAtrIX oSumAtrIX closed this Jul 15, 2022
@ponces ponces deleted the fix-codecs-unlock branch July 15, 2022 12:42
@ponces
Copy link
Author

ponces commented Jul 15, 2022

New PR pushed!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants