Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(youtube): add Player Flyout Menu patch #2295

Merged
merged 16 commits into from
Jul 30, 2023
Merged

feat(youtube): add Player Flyout Menu patch #2295

merged 16 commits into from
Jul 30, 2023

Conversation

johnconner122
Copy link

@johnconner122 johnconner122 commented May 28, 2023 •
edited by LisoUseInAIKyrios
Loading

closes: ReVanced/revanced-patches-template#1968, ReVanced/revanced-patches-template#1805

depends on:

@johnconner122 johnconner122 mentioned this pull request May 28, 2023
Merged
2 tasks
oSumAtrIX
oSumAtrIX approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 The integrations code also looks ready but is marked as a draft, is that intentional?

@johnconner122
Copy link
Author

johnconner122 commented May 28, 2023 •
edited
Loading

but is marked as a draft, is that intentional?

It has TODO's (remove bug and testing)

@johnconner122 johnconner122 requested a review from oSumAtrIX May 28, 2023 19:54
@johnconner122
Copy link
Author

Accidental click for review 😬

@johnconner122
Copy link
Author

johnconner122 commented Jun 1, 2023 •
edited
Loading

@oSumAtrIX On side note some patch depend on LithoFilterPatch, if user doesn't select one of those patches, and patches the app, then components will still be filtered. We should add a check or change SettingsEnum values to false and change their default values in patch class if included.

@oSumAtrIX
Copy link
Member

This is known. Instead, a hook should be added for each patch.

@LisoUseInAIKyrios
Copy link

Could this also hide the new "add to play next queue"?

@johnconner122
Copy link
Author

johnconner122 commented Jun 24, 2023 •
edited
Loading

Could this also hide the new "add to play next queue"?

Theoritically, yes. If you know component's name.

@johnconner122
Copy link
Author

@LisoUseInAIKyrios this PR is not implementing ReVanced/revanced-patches-template#960, why did you link the issue?

@LisoUseInAIKyrios
Copy link

I saw some of the options were part of this. But now I see that is a duplicate of other requests.

@johnconner122 johnconner122 requested a review from oSumAtrIX July 1, 2023 12:11
@johnconner122 johnconner122 changed the title feat(youtube): add player-flyout-menu-panel patch feat(youtube): add player-flyout-menu patch Jul 1, 2023
@johnconner122 johnconner122 changed the title feat(youtube): add player-flyout-menu patch feat(youtube): add Player Flyout Menu patch Jul 22, 2023
@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into player-flyout-panel
1abbe44
@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into player-flyout-panel
66efd13 
# Conflicts:
#	src/main/kotlin/app/revanced/patches/youtube/layout/hide/watchinvr/patch/WatchInVRPatch.kt
@LisoUseInAIKyrios
Copy link

Is this ready to merge?

@johnconner122
Copy link
Author

Is this ready to merge?

YES

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit aea0af0 into ReVanced:dev Jul 30, 2023
revanced-bot pushed a commit that referenced this pull request Jul 30, 2023
@semantic-release-bot
chore(release): 2.187.0-dev.7 [skip ci]
eb5aed9 
# [2.187.0-dev.7](ReVanced/revanced-patches@v2.187.0-dev.6...v2.187.0-dev.7) (2023-07-30)

### Features

* **YouTube:** add `Player Flyout Menu` patch ([#2295](ReVanced/revanced-patches#2295)) ([aea0af0](ReVanced/revanced-patches@aea0af0))
@johnconner122 johnconner122 deleted the player-flyout-panel branch August 1, 2023 13:47
revanced-bot pushed a commit that referenced this pull request Aug 2, 2023
@semantic-release-bot
chore(release): 2.187.0 [skip ci]
76bab10 
# [2.187.0](ReVanced/revanced-patches@v2.186.0...v2.187.0) (2023-08-02)

### Bug Fixes

* Remove version numbers from individual patches ([#2709](ReVanced/revanced-patches#2709)) ([7a828ea](ReVanced/revanced-patches@7a828ea))
* **Sync for Reddit - Change OAuth client id:** Disable piracy detection ([cd103dd](ReVanced/revanced-patches@cd103dd))
* Use clearer descriptions ([8dbb0e2](ReVanced/revanced-patches@8dbb0e2))
* **YouTube - Spoof app version:** Fix grammar in description ([#2711](ReVanced/revanced-patches#2711)) ([dd249e6](ReVanced/revanced-patches@dd249e6))
* **YouTube - Spoof App Version:** Remove 17.30.35 target (version no longer works correctly) ([#2703](ReVanced/revanced-patches#2703)) ([210108b](ReVanced/revanced-patches@210108b))
* **YouTube - Theme:** only set splash screen color if background colors are set ([f058db4](ReVanced/revanced-patches@f058db4))

### Features

* **Joey for Reddit:** Add `Change OAuth client id` patch ([1bac47d](ReVanced/revanced-patches@1bac47d))
* **Joey for Reddit:** Add `Disable ads` patch ([ad7e147](ReVanced/revanced-patches@ad7e147))
* **Reddit is Fun - Spoof client:** Spoof the user agent ([b9aaf61](ReVanced/revanced-patches@b9aaf61))
* **Sync for Reddit:** add `Disable Sync for Lemmy bottom sheet` patch ([56b535b](ReVanced/revanced-patches@56b535b))
* **YouTube - Hide layout components:** Hide `chips shelf` ([#2699](ReVanced/revanced-patches#2699)) ([8e6058b](ReVanced/revanced-patches@8e6058b))
* **YouTube:** add `Player Flyout Menu` patch ([#2295](ReVanced/revanced-patches#2295)) ([aea0af0](ReVanced/revanced-patches@aea0af0))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this pull request Sep 3, 2023
@johnconner122 @oSumAtrIX @LisoUseInAIKyrios
feat(YouTube): add Player Flyout Menu patch (ReVanced#2295)
6c482a9 
Co-authored-by: oSumAtrIX <[email protected]>
Co-authored-by: LisoUseInAIKyrios <[email protected]>
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this pull request Sep 3, 2023
@semantic-release-bot
chore(release): 2.187.0-dev.7 [skip ci]
9b13347 
# [2.187.0-dev.7](ReVanced/revanced-patches@v2.187.0-dev.6...v2.187.0-dev.7) (2023-07-30)

### Features

* **YouTube:** add `Player Flyout Menu` patch ([ReVanced#2295](ReVanced/revanced-patches#2295)) ([aea0af0](ReVanced/revanced-patches@6c482a9))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this pull request Sep 3, 2023
@semantic-release-bot
chore(release): 2.187.0 [skip ci]
89bcb32 
# [2.187.0](ReVanced/revanced-patches@v2.186.0...v2.187.0) (2023-08-02)

### Bug Fixes

* Remove version numbers from individual patches ([ReVanced#2709](ReVanced/revanced-patches#2709)) ([7a828ea](ReVanced/revanced-patches@b93d8b2))
* **Sync for Reddit - Change OAuth client id:** Disable piracy detection ([cd103dd](ReVanced/revanced-patches@695cd04))
* Use clearer descriptions ([8dbb0e2](ReVanced/revanced-patches@111e28c))
* **YouTube - Spoof app version:** Fix grammar in description ([ReVanced#2711](ReVanced/revanced-patches#2711)) ([dd249e6](ReVanced/revanced-patches@e1d6f97))
* **YouTube - Spoof App Version:** Remove 17.30.35 target (version no longer works correctly) ([ReVanced#2703](ReVanced/revanced-patches#2703)) ([210108b](ReVanced/revanced-patches@c8fa3b4))
* **YouTube - Theme:** only set splash screen color if background colors are set ([f058db4](ReVanced/revanced-patches@725ed82))

### Features

* **Joey for Reddit:** Add `Change OAuth client id` patch ([1bac47d](ReVanced/revanced-patches@d7b5d54))
* **Joey for Reddit:** Add `Disable ads` patch ([ad7e147](ReVanced/revanced-patches@a96b888))
* **Reddit is Fun - Spoof client:** Spoof the user agent ([b9aaf61](ReVanced/revanced-patches@21e93cb))
* **Sync for Reddit:** add `Disable Sync for Lemmy bottom sheet` patch ([56b535b](ReVanced/revanced-patches@9c0568e))
* **YouTube - Hide layout components:** Hide `chips shelf` ([ReVanced#2699](ReVanced/revanced-patches#2699)) ([8e6058b](ReVanced/revanced-patches@b2510d8))
* **YouTube:** add `Player Flyout Menu` patch ([ReVanced#2295](ReVanced/revanced-patches#2295)) ([aea0af0](ReVanced/revanced-patches@6c482a9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oSumAtrIX oSumAtrIX Awaiting requested review from oSumAtrIX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnconner122 @oSumAtrIX @LisoUseInAIKyrios