fix(YouTube - Theme): Resolve dark mode startup crash with Android 9.0

ReVanced · Mar 9, 2025 · 741c2d5 · 741c2d5
1 parent ef278d6
commit 741c2d5
Showing 1 changed file with 23 additions and 22 deletions.
diff --git a/patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt b/patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt
@@ -185,29 +185,30 @@ val themePatch = bytecodePatch(
                     // Fix the splash screen dark mode background color.
                     // In 19.32+ the dark mode splash screen is white and fades to black.
                     // Maybe it's a bug in YT, or maybe it intentionally. Who knows.
-                    document("res/values-night/styles.xml").use { document ->
-                        val resourcesNode = document.getElementsByTagName("resources").item(0) as Element
-                        val childNodes = resourcesNode.childNodes
-
-                        for (i in 0 until childNodes.length) {
-                            val node = childNodes.item(i) as? Element ?: continue
-                            val nodeAttributeName = node.getAttribute("name")
-                            if (nodeAttributeName.startsWith("Theme.YouTube.Launcher")) {
-                                val nodeAttributeParent = node.getAttribute("parent")
-
-                                val style = document.createElement("style")
-                                style.setAttribute("name", "Theme.YouTube.Home")
-                                style.setAttribute("parent", nodeAttributeParent)
-
-                                val windowItem = document.createElement("item")
-                                windowItem.setAttribute("name", "android:windowBackground")
-                                windowItem.textContent = "@color/$splashBackgroundColor"
-                                style.appendChild(windowItem)
-
-                                resourcesNode.removeChild(node)
-                                resourcesNode.appendChild(style)
-                            }
+                    document("res/values-night-v27/styles.xml").use { document ->
+                        // Create a night mode specific override for the splash screen background.
+                        val style = document.createElement("style")
+                        style.setAttribute("name", "Theme.YouTube.Home")
+                        style.setAttribute("parent", "@style/Base.V27.Theme.YouTube.Home")
+
+                        // Fix status and navigation bar showing white on some Android devices,
+                        // such as SDK 28 Android 10 medium tablet.
+                        val colorSplashBackgroundColor = "@color/$splashBackgroundColor"
+                        arrayOf(
+                            "android:navigationBarColor" to colorSplashBackgroundColor,
+                            "android:windowBackground" to colorSplashBackgroundColor,
+                            "android:colorBackground" to colorSplashBackgroundColor,
+                            "colorPrimaryDark" to colorSplashBackgroundColor,
+                            "android:windowLightStatusBar" to "false",
+                        ).forEach { (name, value) ->
+                            val styleItem = document.createElement("item")
+                            styleItem.setAttribute("name", name)
+                            styleItem.textContent = value
+                            style.appendChild(styleItem)
                         }
+
+                        val resourcesNode = document.getElementsByTagName("resources").item(0) as Element
+                        resourcesNode.appendChild(style)
                     }
                 }
             }