Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(YouTube - Hide player components): Disable suggested video end screen shows different video thumbnail and autoplay button in miniplayer #2803

Closed
3 tasks done
ILoveOpenSourceApplications opened this issue Mar 2, 2024 · 9 comments · Fixed by #4502 or #4470
Closed
3 tasks done

bug(YouTube - Hide player components): Disable suggested video end screen shows different video thumbnail and autoplay button in miniplayer #2803

ILoveOpenSourceApplications opened this issue Mar 2, 2024 · 9 comments · Fixed by #4502 or #4470
Labels
Bug report Something isn't working

Comments

@ILoveOpenSourceApplications
Copy link
Contributor

Bug description

While the user finishes watching a video, the preview when minimized shows a different video thumbnail as well as the autoplay button rather than the videos last frame and replay button.
In ReVanced (with disable suggested video end screen turned on):

303494750-bdc863f3-8baa-4f88-8288-961908a1b77d.mp4

In Stock YouTube:

303549484-7f0c6d1b-4f9b-4465-a719-64c64ff4b5fd.mp4

Error logs

No response

Solution

No response

Additional context

The suggested video overlay is hidden if the user stays on portrait or full screen mode. But if minimized it bugs and shows the thumbnail of the suggested video with the autoplay button which disappears after previewing and minimizing once again.

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Mar 2, 2024
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug(YouTube/Disable Suggested Endscreen): Suggested video thumbnail in minimized player bug (YouTube/Disable Suggested Video Endscreen): Suggested video thumbnail and autoplay button in minimized player Mar 2, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

Replication steps:

  1. Play a video.
  2. Skip till there's 10 seconds left in the video.
  3. Minimize the video and let it it play till the end.
  4. Suggested video thumbnail and auto play button appears.
  5. Expanding and minimizing fixes the issue.

tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.188.0-dev.13 [skip ci]
d8ef855 
# [2.188.0-dev.13](ReVanced/revanced-patches@v2.188.0-dev.12...v2.188.0-dev.13) (2023-08-13)

### Features

* **YouTube - External downloads:** Recommend Seal instead of PowerTube ([ReVanced#2803](ReVanced/revanced-patches#2803)) ([082e067](ReVanced/revanced-patches@082e067))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.188.0 [skip ci]
933e88e 
# [2.188.0](ReVanced/revanced-patches@v2.187.0...v2.188.0) (2023-08-26)

### Bug Fixes

* allow using `PreferenceScreen` outside of current module ([fe94013](ReVanced/revanced-patches@fe94013))
* **Client spoof:** Remove exception from option ([9c69f87](ReVanced/revanced-patches@9c69f87))
* **Enable android debugging:** Update patch description ([ReVanced#2869](ReVanced/revanced-patches#2869)) ([d9f0d08](ReVanced/revanced-patches@d9f0d08))
* improve wording ([26f9b05](ReVanced/revanced-patches@26f9b05))
* **Reddit is Fun - Spoof client:** Use a more convincing user agent ([236a18f](ReVanced/revanced-patches@236a18f))
* remove newline ([545388b](ReVanced/revanced-patches@545388b))
* **Tiktok - Show seekbar:** Bump compatibility ([ReVanced#2737](ReVanced/revanced-patches#2737)) ([08413bd](ReVanced/revanced-patches@08413bd))
* **YouTube - Client spoof:** Adjust spoof signature settings description ([ReVanced#2760](ReVanced/revanced-patches#2760)) ([f71d893](ReVanced/revanced-patches@f71d893))
* **YouTube Music - Remove upgrade button:** Remove the correct navigation bar item ([fd3813f](ReVanced/revanced-patches@fd3813f))

### Features

* Add `Override certificate pinning` patch ([ReVanced#2781](ReVanced/revanced-patches#2781)) ([94ed738](ReVanced/revanced-patches@94ed738))
* **Change package name:** Append `.revanced` to package name by default ([ReVanced#2750](ReVanced/revanced-patches#2750)) ([e83e62f](ReVanced/revanced-patches@e83e62f))
* **Duolingo:** Add `Unlock Duolingo Super` patch ([ReVanced#2862](ReVanced/revanced-patches#2862)) ([61a7533](ReVanced/revanced-patches@61a7533))
* Exclude `Custom branding` patch by default ([d6de957](ReVanced/revanced-patches@d6de957))
* **Lightroom:** Add `Disable mandatory login` patch ([ReVanced#2738](ReVanced/revanced-patches#2738)) ([896a713](ReVanced/revanced-patches@896a713))
* **Lightroom:** Add `Unlock premium` patch ([ReVanced#2740](ReVanced/revanced-patches#2740)) ([e18a9bc](ReVanced/revanced-patches@e18a9bc))
* **Nova Launcher:** Remove `Unlock prime` patch ([bbde91c](ReVanced/revanced-patches@bbde91c))
* Publicize resource utility functions ([20aff26](ReVanced/revanced-patches@20aff26))
* **Solid Explorer:** Add `Remove file size limit` patch ([01c617d](ReVanced/revanced-patches@01c617d))
* **Strava:** Add `Subscription features` patch ([ReVanced#2872](ReVanced/revanced-patches#2872)) ([387eb29](ReVanced/revanced-patches@387eb29))
* **Tasker:** Remove `Unlock trial` patch ([8354a87](ReVanced/revanced-patches@8354a87))
* Use an extension property to create new exception when failing to resolve a fingerprint ([47eac14](ReVanced/revanced-patches@47eac14))
* **YouTube - Debug:** Logging of layout proto buffer strings ([ReVanced#2759](ReVanced/revanced-patches#2759)) ([189f719](ReVanced/revanced-patches@189f719))
* **YouTube - External downloads:** Recommend Seal instead of PowerTube ([ReVanced#2803](ReVanced/revanced-patches#2803)) ([082e067](ReVanced/revanced-patches@082e067))
* **YouTube - Hide video action buttons:** Hide individual action buttons ([ReVanced#2723](ReVanced/revanced-patches#2723)) ([220f694](ReVanced/revanced-patches@220f694))
* **YouTube Music - Exclusive audio playback:** Support latest version ([0861991](ReVanced/revanced-patches@0861991))
* **YouTube Music:** Add `Permanent repeat` patch ([ReVanced#2722](ReVanced/revanced-patches#2722)) ([506d49c](ReVanced/revanced-patches@506d49c))
* **YouTube Music:** Add `Permanent Shuffle` patch ([ReVanced#2730](ReVanced/revanced-patches#2730)) ([86a271c](ReVanced/revanced-patches@86a271c))
* **YouTube:** Add `Alternative thumbnails` patch ([ReVanced#2834](ReVanced/revanced-patches#2834)) ([8a4277c](ReVanced/revanced-patches@8a4277c))
* **YouTube:** Add `Custom player overlay opacity` patch ([ReVanced#2721](ReVanced/revanced-patches#2721)) ([2622b00](ReVanced/revanced-patches@2622b00))
* **YouTube:** Add `Enable tablet layout` patch ([c89b2aa](ReVanced/revanced-patches@c89b2aa))
* **YouTube:** Support version `18.29.38` ([c1b9eef](ReVanced/revanced-patches@c1b9eef))
* **YouTube:** Support version `18.32.39` ([7b503e2](ReVanced/revanced-patches@7b503e2))
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug (YouTube/Disable Suggested Video Endscreen): Suggested video thumbnail and autoplay button in minimized player bug (YouTube/Disable suggested video endscreen): Suggested video thumbnail and autoplay button in minimized player Apr 15, 2024
@ILoveOpenSourceApplications
Copy link
Contributor Author

ILoveOpenSourceApplications commented May 9, 2024 •
edited
Loading

There's a toggle in 'Autoplay' called Autoplay next video below which is an option called 'Mobile phone/tablet'. If turned off there'll be no suggested video end screen and if turned on it'll be there. So we can remove this patch, but guide the users to this option similar to how we are doing for the background playback option.

Edit: Please refer this comment for further clarity.

@ILoveOpenSourceApplications
Copy link
Contributor Author

The commit was also provided by @inotia00.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug (YouTube/Disable suggested video endscreen): Suggested video thumbnail and autoplay button in minimized player bug(YouTube - Disable suggested video endscreen): Suggested video thumbnail and autoplay button in minimized player Jun 2, 2024
@ILoveOpenSourceApplications ILoveOpenSourceApplications changed the title bug(YouTube - Disable suggested video endscreen): Suggested video thumbnail and autoplay button in minimized player bug(YouTube - Hide player components): Disable suggested video end screen shows different video thumbnail and autoplay button in miniplayer Feb 17, 2025
@ILoveOpenSourceApplications
Copy link
Contributor Author

@LisoUseInAIKyrios, could this be something you can look into?

@LisoUseInAIKyrios
Copy link
Contributor

Since it's a glitch causes by RV hiding the end screen cards, I would guess that fixing it may be overly complex.

@ILoveOpenSourceApplications
Copy link
Contributor Author

This is how it's solved over ar RVX.

@ILoveOpenSourceApplications
Copy link
Contributor Author

Is this a complex solution?

@LisoUseInAIKyrios
Copy link
Contributor

I did not see the mentioned commit. No that doesn't look that complex.

@ILoveOpenSourceApplications
Copy link
Contributor Author

So, can this be PR'd?

Merged
This was linked to pull requests Feb 25, 2025
fix(YouTube - Hide player components): Show correct end video thumbnail if Hide end screen suggested video is enabled #4502
Merged
chore: Merge branch dev to main #4470
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@ILoveOpenSourceApplications @LisoUseInAIKyrios