Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Video data continues to download when screen is off #542

Closed
3 tasks done
jwidness opened this issue Jul 30, 2023 · 3 comments
Closed
3 tasks done

bug: Video data continues to download when screen is off #542

jwidness opened this issue Jul 30, 2023 · 3 comments
Labels
Bug report Something isn't working

Comments

@jwidness
Copy link

Type

Error at runtime

Bug description

When I play YT in the background (with screen on or off), ReVanced correctly knows not to download video data, only audio. But when I leave a video running in the foreground and turn off my screen, all the video data is downloaded even though only the audio is needed.

Also reported here: https://www.reddit.com/r/revancedapp/comments/10n36xk/data_usage_with_screen_off/

Steps to reproduce

  • Open a video
  • Without switching to background play, turn off screen
  • After video finishes, note the amount of data used

Compare to:

  • Open a video
  • Switch to background mode, then turn off screen
  • Note that data usage is much lower

I'm having this problem after updating to the latest versions of everything, but it was also true on the version I downloaded in April.

Relevant log output

NA

Screenshots or videos

No response

Solution

I think the expected behavior is to not download video data when the screen is off.

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@jwidness jwidness added the Bug report Something isn't working label Jul 30, 2023
@LisoUseInAIKyrios
Copy link
Contributor

This YouTube behavior and is not specific to ReVanced.

@jwidness
Copy link
Author

I did not have this issue the last time I used the stock YT app.

@LisoUseInAIKyrios
Copy link
Contributor

Try again with stock YouTube.

Also try ReVanced with no patches enabled except microg. If the behavior is the same with only microg then it's definitively not a ReVanced issue because at that point you're using stock YouTube. If the problem is fixed when all patches are excluded, then start repatching and including more patches until the problem returns. Then report back which patch caused the problem.

And if you don't care enough to do any of this, then simply switch to pip mode first and turn on audio only mode (press headphones icon).

If you identify a ReVanced patch as the issue (where the issue is present when the patch is included, and the issue is not present when the patch is excluded), then reopen this bug report with that information.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants